<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106274/">http://git.reviewboard.kde.org/r/106274/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I can't test it at the moment, but the change looks small and safe enough, and I trust that you have tested it, so a fast review is fine for me :-)
Please create a bug report and close it with your commit to make sure that this is included in the changelog.
About the merge/cherry-pick question: I have always cherry-picked in the past, but sometimes people do merge in kde-baseapps. Unfortunately, the combination of the two results in a big mess in the output of git log and qgit. Maybe we should discuss this with all projects in kde-baseapps and agree on a common workflow...</pre>
<br />
<p>- Frank</p>
<br />
<p>On August 30th, 2012, 11:08 a.m., Vishesh Handa wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Dolphin and Nepomuk.</div>
<div>By Vishesh Handa.</div>
<p style="color: grey;"><i>Updated Aug. 30, 2012, 11:08 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"> Dolphin is a file manager, and shouldn't be concerned with non-file
resources like notes, contacts and other stuff.
Use FileQuery instead of Query.
This also results in a faster queries. With File Queries Nepomuk can
perform some internal optimizations.
PS: I'd like to get this into 4.9.1, so a fast review would be nice. Also, do we cherry pick or merge KDE/4.9 into master?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>dolphin/src/panels/places/placesitemmodel.cpp <span style="color: grey">(4979013)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106274/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>