<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105986/">http://git.reviewboard.kde.org/r/105986/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 15th, 2012, 7:44 a.m., <b>Sebastian Trueg</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/105986/diff/4/?file=77765#file77765line62" style="color: black; font-weight: bold; text-decoration: underline;">services/fileindexer/nepomukindexer.cpp</a>
<span style="font-weight: normal;">
(Diff revision 4)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void Nepomuk2::Indexer::start()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">62</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="tb"> </span><span class="n">args</span> <span class="o"><<</span> <span class="n">skip</span><span class="p">.</span><span class="n">append</span><span class="p">(</span><span class="n">str</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Does this not result in "--skipDigestEventAnalyzer"? Is that what should be done? I would rather think it needs to be:
args << skip << str;</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Actually it's ok; there's a space at the end of QLatin1String("--skip ").
What I have now creates a list:
("--skip DigestEventAnalyzer",)
and what you suggest would make:
("--skip ", "DigestEventAnalyzer")
The code for the second is perhaps clearer, but it splits up options that logically remain together. </pre>
<br />
<p>- Simeon</p>
<br />
<p>On August 14th, 2012, 9:22 p.m., Simeon Bird wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Nepomuk, Vishesh Handa and Sebastian Trueg.</div>
<div>By Simeon Bird.</div>
<p style="color: grey;"><i>Updated Aug. 14, 2012, 9:22 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This fixes https://bugs.kde.org/show_bug.cgi?id=303670 by disabling the SHA1 analyzer in strigi.
I added an extra argument to nepomukindexer, --skip, which takes a comma-separated list of analyzers to not call.
Then I change the invocation of nepomukindexer from the FileIndexer class so that it gets this list from a hidden option (exclude plugins) in the nepomuk config, which defaults to the SHA1 indexer.
I didn't add a KCM option because a) I don't know how to do that (this is the real reason :) ), and b) I'm not sure whether it should be a "disable SHA1" checkbox, a list, or whether we need it at all.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Compiled, tested that nepomukindexer indeed does not call DigestEventAnalyzer with some printing. </pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=303670">303670</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>services/fileindexer/fileindexerconfig.h <span style="color: grey">(cc00922)</span></li>
<li>services/fileindexer/fileindexerconfig.cpp <span style="color: grey">(e2265fc)</span></li>
<li>services/fileindexer/indexer/indexer.h <span style="color: grey">(dc0e98a)</span></li>
<li>services/fileindexer/indexer/indexer.cpp <span style="color: grey">(e4f1462)</span></li>
<li>services/fileindexer/indexer/main.cpp <span style="color: grey">(a46a651)</span></li>
<li>services/fileindexer/nepomukindexer.cpp <span style="color: grey">(70abee0)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105986/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>