<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105986/">http://git.reviewboard.kde.org/r/105986/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Nepomuk, Vishesh Handa and Sebastian Trueg.</div>
<div>By Simeon Bird.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This fixes https://bugs.kde.org/show_bug.cgi?id=303670 by disabling the SHA1 analyzer in strigi.
I added an extra argument to nepomukindexer, --skip, which takes a comma-separated list of analyzers to not call.
Then I change the invocation of nepomukindexer from the FileIndexer class so that it gets this list from a hidden option (exclude plugins) in the nepomuk config, which defaults to the SHA1 indexer.
I didn't add a KCM option because a) I don't know how to do that (this is the real reason :) ), and b) I'm not sure whether it should be a "disable SHA1" checkbox, a list, or whether we need it at all.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Compiled, tested that nepomukindexer indeed does not call DigestEventAnalyzer with some printing. </pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=303670">303670</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>services/fileindexer/fileindexerconfig.h <span style="color: grey">(cc00922)</span></li>
<li>services/fileindexer/fileindexerconfig.cpp <span style="color: grey">(e2265fc)</span></li>
<li>services/fileindexer/indexer/indexer.h <span style="color: grey">(dc0e98a)</span></li>
<li>services/fileindexer/indexer/indexer.cpp <span style="color: grey">(e4f1462)</span></li>
<li>services/fileindexer/indexer/main.cpp <span style="color: grey">(a46a651)</span></li>
<li>services/fileindexer/nepomukindexer.cpp <span style="color: grey">(70abee0)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105986/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>