<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105872/">http://git.reviewboard.kde.org/r/105872/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 5th, 2012, 12:11 p.m., <b>Vishesh Handa</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Nice work!
I'm not sure about the last point - "Speed up searchRunnable.run() by storing up to 10 results in the result list before sending them to folder.addResults(). This should be faster by needing less locking overhead. I haven't actually timed it, so it may be marginal."
I've actually tried this before, and seen no actual performance benefit. Without actual benchmarks, I'm not sure I would like to have this. Anyway, could you please split the last point in another patch? (Try a git add -p, it's awesome!)</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ok - I guess if hits.result() is fairly heavy the locking won't make any difference. If you tested it and it didn't, it makes sense to drop that bit.</pre>
<br />
<p>- Simeon</p>
<br />
<p>On August 5th, 2012, 5:34 p.m., Simeon Bird wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Nepomuk, Vishesh Handa and Sebastian Trueg.</div>
<div>By Simeon Bird.</div>
<p style="color: grey;"><i>Updated Aug. 5, 2012, 5:34 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is a fairly trivial patch to port the QueryService to the Query::ResultIterator; just doing something quick to get my hand in.
- Changes ResourceManager::mainModel() use in QueryService to ResourceIterator
- Removes now unneeded includes, functions, etc
- Speed up searchRunnable.run() by storing up to 10 results in the result list before sending them to folder.addResults(). This should be faster by needing less locking overhead. I haven't actually timed it, so it may be marginal.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Compiles, dolphin search still works.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=303383">303383</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>services/queryservice/searchrunnable.h <span style="color: grey">(1c12a9b)</span></li>
<li>services/queryservice/searchrunnable.cpp <span style="color: grey">(451db46)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105872/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>