<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105755/">http://git.reviewboard.kde.org/r/105755/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On July 28th, 2012, 12:36 p.m., <b>Vishesh Handa</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I have just been informed that the tarballs for nepomuk-core have already been spun. Could we please please re-spin them, and include this patch. I don't care about the rest. They are just bug fixes.
This one removes an entire class, and if KDE 4.9, goes out without this patch, I can never remove it. Not until Frameworks.</pre>
</blockquote>
<p>On July 30th, 2012, 6:16 p.m., <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">What about things like kde-runtime/nepomuk/kioslaves/nepomuk/kio_nepomuk.cpp ?</pre>
</blockquote>
<p>On July 30th, 2012, 6:22 p.m., <b>Vishesh Handa</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">We just need to remove the headers includes.
If it's too much of a problem, then it's fine. I'll deprecate the class in master (or just let it be), and live with it.</pre>
</blockquote>
<p>On July 30th, 2012, 6:25 p.m., <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Do you have a list of all the tarballs that need to be remade?</pre>
</blockquote>
<p>On July 30th, 2012, 6:28 p.m., <b>Vishesh Handa</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">nepomuk-core and kde-runtime.
You'll anyway have to remake nepomuk-core for the windows stuff (if we want, otherwise they can just patch it themselves).</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">What about http://lxr.kde.org/source/playground/network/telepathy/ktp-nepomuk-service/nepomuk-storage.cpp#36 http://lxr.kde.org/source/playground/network/telepathy/ktp-nepomuk-service/tests/storage-test.cpp#41 http://lxr.kde.org/source/playground/network/telepathy/ktp-nepomuk-service/tests/tid-base-test.cpp#29 http://lxr.kde.org/source/playground/pim/zanshin/src/itemview/itemcontext.cpp#47 http://lxr.kde.org/source/playground/pim/zanshin/src/itemview/nepomukcontextmodel.cpp#36 http://lxr.kde.org/source/playground/pim/zanshin/src/utils/queries.cpp#30 http://lxr.kde.org/source/playground/pim/zanshin/src/utils/tagmanager.h#32
Are we fine breaking them?
Also can you guess-estimate the maintaince burden of this class being present during 4.9.x? Do you forsee it breaking/causing problems/making other fixes difficult to do?</pre>
<br />
<p>- Albert</p>
<br />
<p>On July 27th, 2012, 2:37 p.m., Vishesh Handa wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Nepomuk, Release Team and Sebastian Trueg.</div>
<div>By Vishesh Handa.</div>
<p style="color: grey;"><i>Updated July 27, 2012, 2:37 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">No one uses it, and the same class can be generated using the rcgen.
I don't see the point of having this class.
This is my last chance to remove this old code. Otherwise I'll have to wait till KDE Frameworks 5.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>includes/CMakeLists.txt <span style="color: grey">(4ac2d7c)</span></li>
<li>includes/Thing <span style="color: grey">(952544e)</span></li>
<li>libnepomukcore/CMakeLists.txt <span style="color: grey">(066c898)</span></li>
<li>libnepomukcore/resource/thing.h <span style="color: grey">(2ae3d75)</span></li>
<li>libnepomukcore/resource/thing.cpp <span style="color: grey">(59f2a4d)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105755/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>