<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/105726/">http://git.reviewboard.kde.org/r/105726/</a>
     </td>
    </tr>
   </table>
   <br />





<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
 <p style="margin-top: 0;">On July 25th, 2012, 5:59 p.m., <b>Sebastian Trueg</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Actually they should be in a top-level dir rather than in subdirs. I think all tests should be in a "tests" folder - or something like that. Isn't that also what the K5 spec says?</pre>
 </blockquote>







</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">They say it should go in 'autotests'. We can the libnepomukcore tests over there, if you want.

http://community.kde.org/Frameworks/Strategy_and_Policies#Framework_directory_structure</pre>
<br />








<p>- Vishesh</p>


<br />
<p>On July 25th, 2012, 11:55 a.m., Vishesh Handa wrote:</p>






<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for Nepomuk and Sebastian Trueg.</div>
<div>By Vishesh Handa.</div>


<p style="color: grey;"><i>Updated July 25, 2012, 11:55 a.m.</i></p>






<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">They do not belong in the storage service any more.
</pre>
  </td>
 </tr>
</table>





<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>libnepomukcore/test/CMakeLists.txt <span style="color: grey">(4a6f9d8)</span></li>

 <li>libnepomukcore/test/simpleresourceclassestest.h <span style="color: grey">(PRE-CREATION)</span></li>

 <li>libnepomukcore/test/simpleresourceclassestest.cpp <span style="color: grey">(PRE-CREATION)</span></li>

 <li>services/storage/test/CMakeLists.txt <span style="color: grey">(b668521)</span></li>

 <li>services/storage/test/simpleresourceclassestest.h <span style="color: grey">(8593427)</span></li>

 <li>services/storage/test/simpleresourceclassestest.cpp <span style="color: grey">(da0e0e6)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/105726/diff/" style="margin-left: 3em;">View Diff</a></p>




  </td>
 </tr>
</table>








  </div>
 </body>
</html>