<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105622/">http://git.reviewboard.kde.org/r/105622/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 8a1ceb4d3f1fa12e833df0c6a93e7bbacf4d2f54 by Vishesh Handa to branch KDE/4.9.</pre>
<br />
<p>- Commit</p>
<br />
<p>On July 19th, 2012, 2:35 p.m., Vishesh Handa wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Nepomuk and Sebastian Trueg.</div>
<div>By Vishesh Handa.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Improve the concepts of kickoff lists and make the code a lot easier to
understand. Most of the "magic" of the kickoff lists has been removed to
make it more explicit, and easier to understand.
Instead of having one kickOff list for everything. We now have 3 lists -
* One for initialized data. Maps uri -> ResourceData*
* One for nao:identifiers. Maps nao:identifier -> ResourceData*
* One for nie:urls. Maps nie:urls -> ResourceData*
When constructing a ResourceData, the ResourceManager checks the kind
QUrl it has been given - a nepomukuri, a nie:url or nao:identifier.
Based on the results it passes the arguemnts to the ResourceData
constrcutor.
This change was only possible cause with the DMS, we have made it clear
that all resource uri's will be of the form 'nepomuk:/'. This makes the
logic a lot simpler.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I've run the tests, and there are no regressions, and this actually fixes on test.
But a lot of tests still fail (around 9), so there is still work to be done. This is just the first step.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libnepomukcore/resource/resourcedata.h <span style="color: grey">(1d0d761)</span></li>
<li>libnepomukcore/resource/resourcedata.cpp <span style="color: grey">(37b48f2)</span></li>
<li>libnepomukcore/resource/resourcemanager.cpp <span style="color: grey">(8f45289)</span></li>
<li>libnepomukcore/resource/resourcemanager_p.h <span style="color: grey">(1547f5e)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105622/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>