<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105597/">http://git.reviewboard.kde.org/r/105597/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Regarding the installation of files: IMHO it would be better to not install files since tests normally do not do that. If you need to have a special folder for things like the config files just use one in the build dir and let cmake hardcode the path somewhere.</pre>
<br />
<p>- Sebastian</p>
<br />
<p>On July 19th, 2012, 9:41 a.m., Vishesh Handa wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Nepomuk and Sebastian Trueg.</div>
<div>By Vishesh Handa.</div>
<p style="color: grey;"><i>Updated July 19, 2012, 9:41 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is the Nepomuk Test Framework which I had described months ago over here - http://vhanda.in/blog/2012/03/nepomuk-test-framework/
It is currently in the testLibrary branch in nepomuk-core. This is a diff of testLibrary against KDE/4.9.
The testlib creates mock kde and dbus sessions and then starts Nepomuk. It waits till the nepomuk query service has been started and it then runs the tests. Once the tests have run, it shuts down the mock kde sessions, and destroys the temporary folder in which it was created.
The patch also contains very detailed tests for the Resource class. Most of the tests fail :) It seems like I have a lot of work to do.
I would like to merge this into KDE/4.9. I hope no one has any objections.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes. The tests have been tested.
If you want to run the tests please run them via 'ctest -VV'. Do not run the test executables manually. This would not result in the test environment being setup, and a new virtuoso database would be not be created. This would result in ALL your Nepomuk data being deleted at the end of the test.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(4d5ae3f)</span></li>
<li>autotests/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/README <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/lib/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/lib/NepomukTestLibMacros.cmake.in <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/lib/nepomukserverrc.in <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/lib/nepomuktest_export.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/lib/testbase.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/lib/testbase.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/lib/tools/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/lib/tools/runNepomukTest.sh.in <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/lib/tools/run_in_new_dbus_session.sh <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/lib/tools/with-nepomuk-sandbox.sh.in <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/test/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/test/resourcetests.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>autotests/test/resourcetests.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105597/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>