<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105517/">http://git.reviewboard.kde.org/r/105517/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On July 12th, 2012, 9:49 a.m., <b>Sebastian Trueg</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/105517/diff/1/?file=72089#file72089line92" style="color: black; font-weight: bold; text-decoration: underline;">libnepomukcore/resource/resourcedata.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">namespace Nepomuk2 {</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#ebb1ba" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">92</font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">bool</span> <span class="n">hasType</span><span class="p">(</span> <span class="k">const</span> <span class="n">QUrl</span><span class="o">&</span> <span class="n">uri</span> <span class="p">);</span></pre></td>
<th bgcolor="#ebb1ba" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">hasType(const Types::Class& type)
would be cool instead. Internally it could use property()</pre>
</blockquote>
<p>On July 12th, 2012, 9:55 a.m., <b>Vishesh Handa</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">In ResourceData? Or did you mean in Resource?</pre>
</blockquote>
<p>On July 12th, 2012, 11:33 a.m., <b>Sebastian Trueg</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I meant Resource, yes.</pre>
</blockquote>
<p>On July 14th, 2012, 7:10 a.m., <b>Vishesh Handa</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I was changing hasType(), addType(), and setTypes, but then I noticed that I'll have to change the list from QList<Type::Class> to QList<QUrl>. Do you really want this?</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I don't follow.</pre>
<br />
<p>- Sebastian</p>
<br />
<p>On July 14th, 2012, 7:08 a.m., Vishesh Handa wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Nepomuk and Sebastian Trueg.</div>
<div>By Vishesh Handa.</div>
<p style="color: grey;"><i>Updated July 14, 2012, 7:08 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Remove special handling for rdf:type
This includes storing the maintype when loading all the properties. This
simplifies the code base, and actually improves performace.
Because the type deduction is done during load time, the relevant types
needed to be loaded into memory by Types::EntityPrivate, this increases
the load time for each resource by an order of 5x. This extra load
eventually goes down when all the required types are loaded, but it's
there.
Also, the additional cost of infering the type each time doesn't seem to
have any performance loss. Mainly cause everything is already in memory.
Another reason for this patch is the planned refactoring of the class
internals to use shared memory. Every extra variable in ResourceData
adds an overhead.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Manual + Unit Testing :)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(4d5ae3f971ddd7479ea711097323fd034caecb66)</span></li>
<li>Info.plist.template <span style="color: grey">(PRE-CREATION)</span></li>
<li>includes/CMakeLists.txt <span style="color: grey">(4ac2d7cfcba1522eb73b432533a08b3fd1e148b3)</span></li>
<li>includes/Query/ResultIterator <span style="color: grey">(PRE-CREATION)</span></li>
<li>libnepomukcore/CMakeLists.txt <span style="color: grey">(066c8986dfa2b3150072dbd96a71caf8873cea06)</span></li>
<li>libnepomukcore/datamanagement/createresourcejob.h <span style="color: grey">(7abf51d4c9c3a4bd0c4036234dae006c7b10bfb8)</span></li>
<li>libnepomukcore/datamanagement/resourcewatcher.cpp <span style="color: grey">(0cd846afc8ceb15c7f3614c5f3a0705c76700b24)</span></li>
<li>libnepomukcore/misc/utils.cpp <span style="color: grey">(28747226e631c17767061cbf7bf70e990dc53608)</span></li>
<li>libnepomukcore/query/comparisonterm.cpp <span style="color: grey">(64e5a37e33e73a6828690a9a4a12e2e5215af131)</span></li>
<li>libnepomukcore/query/dbusoperators.cpp <span style="color: grey">(055ea8503b31cee1770de8984f3e829dc92c4437)</span></li>
<li>libnepomukcore/query/queryserializer.cpp <span style="color: grey">(0d8bc7ecc42d8be4d787e31b7dceabfe4ede2759)</span></li>
<li>libnepomukcore/query/resourceterm.cpp <span style="color: grey">(d539f4dd6ebf8362a4d240a8280be05a1a4efb94)</span></li>
<li>libnepomukcore/query/resultiterator.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libnepomukcore/query/resultiterator.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libnepomukcore/query/term.cpp <span style="color: grey">(c99a49e2dc0b5a95ad34ca2bfedb22717e3ca3f3)</span></li>
<li>libnepomukcore/resource/resource.h <span style="color: grey">(3cc30c2cbc44e6e3f5c6fb6218df811d0104950c)</span></li>
<li>libnepomukcore/resource/resource.cpp <span style="color: grey">(c237f44c1420929143299aab391a0f2a7709f894)</span></li>
<li>libnepomukcore/resource/resourcedata.h <span style="color: grey">(370889700cb93dbf93bc6cb4b498fab2470cafba)</span></li>
<li>libnepomukcore/resource/resourcedata.cpp <span style="color: grey">(6fa262f955936637f48c81b0cce6ac9069f37167)</span></li>
<li>libnepomukcore/resource/resourcemanager.cpp <span style="color: grey">(bfbb610ca2bd286114588ea80a3f4c68c540b93c)</span></li>
<li>libnepomukcore/resource/tag.h <span style="color: grey">(d5eb11bd3e68a3c4bbeb5a3ed3412c38e73186a1)</span></li>
<li>libnepomukcore/resource/tag.cpp <span style="color: grey">(14ad18f9ab9b322951e6bf994117687509d1c35d)</span></li>
<li>libnepomukcore/resource/variant.cpp <span style="color: grey">(9d391ce83baaa695cb149408c6c25b9c52d35862)</span></li>
<li>libnepomukcore/test/resourcetest.cpp <span style="color: grey">(82e26c36436f58774b3b86fe1a25d084a65a6217)</span></li>
<li>libnepomukcore/test/tagwidgettest.cpp <span style="color: grey">(c7b37c1720a31a0451977a7e5b4d4d0af0ac91a9)</span></li>
<li>services/backupsync/gui/syncfileidentifier.cpp <span style="color: grey">(0837b26ca1021055e054fa62c0c650269d323fd0)</span></li>
<li>services/backupsync/lib/resourceidentifier.cpp <span style="color: grey">(14e85f1124a8e4e8035ad8f044da11043c4fd6ca)</span></li>
<li>services/backupsync/lib/test/nepomuksynctests.cpp <span style="color: grey">(a9cc2f19b399557bddaca0b19f6d875837fe6cfd)</span></li>
<li>services/backupsync/service/syncmanager.cpp <span style="color: grey">(dbeef86995f3a936a306d15283587aabd2772a45)</span></li>
<li>services/queryservice/folder.cpp <span style="color: grey">(8f82f161868872e255c8b5addf7fefaf17c6e2e7)</span></li>
<li>services/queryservice/folderconnection.cpp <span style="color: grey">(3bc20f52b3d0428f025c1faaeee5625ab980d431)</span></li>
<li>services/queryservice/searchrunnable.cpp <span style="color: grey">(522d6f94c5c897b2537698d2bd764d666f917c98)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105517/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>