<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105265/">http://git.reviewboard.kde.org/r/105265/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On June 15th, 2012, 2:57 p.m., <b>Sebastian Trueg</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/105265/diff/1/?file=67802#file67802line370" style="color: black; font-weight: bold; text-decoration: underline;">nepomuk/core/resourcedata.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void Nepomuk::ResourceData::loadType( const QUrl& storedType )</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">370</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span> <span class="n">storedTypeClass</span><span class="p">.</span><span class="n">isSubClassOf</span><span class="p">(</span> <span class="n">currentTypeClass</span> <span class="p">)</span> <span class="p">)</span> <span class="p">{</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">370</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span> <span class="p">(</span> <span class="o"><span class="hl">!</span></span><span class="n">storedTypeClass</span><span class="p">.</span><span class="n">isSubClassOf</span><span class="p">(</span> <span class="n">currentTypeClass</span> <span class="p">)</span> <span class="p">)</span> <span class="p">{</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">"Note" is a sub class of "HTMLDoc". We want to use "Note" if "HTMLDoc" is our current type. Thus, the test is: if the storedtype (Note) isSubClassOf the current type (HTMLDoc) -> use the stored type.</pre>
</blockquote>
<p>On June 16th, 2012, 6:44 p.m., <b>Vishesh Handa</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Urgh. You're right.
The problem I had was that I have a resource with -
<nepomuk:/res/ff9103bf-e982-4c87-ae3c-a00bc5e459c3>
rdf:type nfo:HtmlDocument
rdf:type nfo:PlainTextDocument
rdf:type nfo:TextDocument
rdf:type nfo:Document
rdf:type nie:InformationElement
rdf:type rdfs:Resource
rdf:type pimo:Note
rdf:type pimo:Document
rdf:type pimo:LogicalMediaType
rdf:type pimo:Thing
rdf:type pimo:ClassOrThing
rdf:type pimo:ClassOrThingOrPropertyOrAssociation
In this case we have 2 trees -
nfo:HtmlDocument -> nfo:PlainTextDocument -> nfo:TextDocument -> nfo:Document -> nfo:InformationElement
pimo:Note -> pimo:Document -> pimo:LogicalMediaType -> pimo:Thing -> pimo:ClassOrThing -> pimo:ClassOrThingOrProperty:OrAssociation
I obviously want pimo:Note, but I often get nfo:Document. Any clue on how to solve this? Always prefer pimo over other ontologies? Cause we are going to have the same problem when we start storing a resource which is both a pimo:Person and a nco:Contact</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Since we have special PIMO handling anyway: why not something like this in addition to the existing check:
if(newType.isSubClassOf(pimo:Thing) && !oldType.isSubClassOf(pimo:Thing))</pre>
<br />
<p>- Sebastian</p>
<br />
<p>On June 15th, 2012, 11:34 a.m., Vishesh Handa wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Nepomuk and Sebastian Trueg.</div>
<div>By Vishesh Handa.</div>
<p style="color: grey;"><i>Updated June 15, 2012, 11:34 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It makes more sense show "Note" instead of "HTML Document".
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>nepomuk/core/resourcedata.cpp <span style="color: grey">(4e8554d)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105265/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>