<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105247/">http://git.reviewboard.kde.org/r/105247/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On June 14th, 2012, 7:28 p.m., <b>Sebastian Trueg</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/105247/diff/1/?file=67595#file67595line105" style="color: black; font-weight: bold; text-decoration: underline;">libnepomukcore/resource/resourcemanager.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">namespace Nepomuk2 {</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">105</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="kt">void</span> <span class="n">setOverrideMainModel</span><span class="p">(</span> <span class="n">Soprano</span><span class="o">::</span><span class="n">Model</span><span class="o">*</span> <span class="n">model</span> <span class="p">);</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">94</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="kt">void</span> <span class="n">setOverrideMainModel</span><span class="p">(</span> <span class="n">Soprano</span><span class="o">::</span><span class="n">Model</span><span class="o">*</span> <span class="n">model</span> <span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Actually we can also remove this as it does not make sense anymore - we are using the DMS for writing now which cannot be replaced.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">A lot of the Nepomuk::Resource tests use this. Should I just throw away those tests?</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On June 14th, 2012, 7:28 p.m., <b>Sebastian Trueg</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/105247/diff/1/?file=67595#file67595line174" style="color: black; font-weight: bold; text-decoration: underline;">libnepomukcore/resource/resourcemanager.h</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">namespace Nepomuk2 {</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">174</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">QList</span><span class="o"><</span><span class="n">Resource</span><span class="o">></span> <span class="n">allResourcesWithProperty</span><span class="p">(</span> <span class="k">const</span> <span class="n">QUrl</span><span class="o">&</span> <span class="n">uri</span><span class="p">,</span> <span class="k">const</span> <span class="n">Variant</span><span class="o">&</span> <span class="n">v</span> <span class="p">);</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">119</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">QList</span><span class="o"><</span><span class="n">Resource</span><span class="o">></span> <span class="n">allResourcesWithProperty</span><span class="p">(</span> <span class="k">const</span> <span class="n">QUrl</span><span class="o">&</span> <span class="n">uri</span><span class="p">,</span> <span class="k">const</span> <span class="n">Variant</span><span class="o">&</span> <span class="n">v</span> <span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Even this could be removed. And if we need method like that why not do something like:
QList<Nepomuk::Resource> somethingBlocking(const Nepomuk::Query::Query& wuery);</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The Nepomuk::Tag class uses it for the tagOf() function. I'll replace it with the somethingBlocking version.</pre>
<br />
<p>- Vishesh</p>
<br />
<p>On June 13th, 2012, 9:06 p.m., Vishesh Handa wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Nepomuk.</div>
<div>By Vishesh Handa.</div>
<p style="color: grey;"><i>Updated June 13, 2012, 9:06 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Remove old code from the ResourceManager
Lesser code is easier to understand, plus we are allowed to break
ABI and API compatibility right now!</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libnepomukcore/resource/resourcemanager.h <span style="color: grey">(012cde5c684cc15bb9983ff35cc95ac03757f679)</span></li>
<li>libnepomukcore/resource/resourcemanager.cpp <span style="color: grey">(f510673944c374cff99fe9cce621601b2a0e9cf2)</span></li>
<li>libnepomukcore/resource/resourcemanager_p.h <span style="color: grey">(2143642e586ff4e5d5f530b0b20340fbe7b81753)</span></li>
<li>libnepomukcore/test/resourcetest.cpp <span style="color: grey">(82e26c36436f58774b3b86fe1a25d084a65a6217)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105247/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>