<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105065/">http://git.reviewboard.kde.org/r/105065/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I am fine with this change.
As for the tests: they are annoying to maintain. What we should have are actual query tests against a test db where the results are compared instead of the query string.</pre>
<br />
<p>- Sebastian</p>
<br />
<p>On May 27th, 2012, 1:37 p.m., Vishesh Handa wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Nepomuk and Sebastian Trueg.</div>
<div>By Vishesh Handa.</div>
<p style="color: grey;"><i>Updated May 27, 2012, 1:37 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If people want them, they should enable them. There is no advantage of providing them by default. Specially since no one seems to be using them. It also complicates the queries when you're trying to debug stuff.
Also, this breaks the existing API a little bit. However, since no one has packaged Nepomuk2 so far, I'm allowed to break stuff.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Not tested. This also breaks almost all the tests in querytest. I'm waiting to see if trueg is okay with this patch.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libnepomukcore/query/query.h <span style="color: grey">(f4360b0)</span></li>
<li>libnepomukcore/query/query.cpp <span style="color: grey">(d67b6ce)</span></li>
<li>libnepomukcore/query/queryserializer.cpp <span style="color: grey">(0d8bc7e)</span></li>
<li>libnepomukcore/test/queryserializertest.cpp <span style="color: grey">(ccc8af6)</span></li>
<li>libnepomukcore/test/querytest.cpp <span style="color: grey">(2a8f685)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105065/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>