<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103794/">http://git.reviewboard.kde.org/r/103794/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Very good. Please port to nepomuk-core.</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/103794/diff/2/?file=48009#file48009line594" style="color: black; font-weight: bold; text-decoration: underline;">nepomuk/services/fileindexer/indexscheduler.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void Nepomuk::IndexScheduler::slotConfigChanged()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">591</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">if</span><span class="p">(</span> <span class="o">!</span><span class="n">forced</span> <span class="o">&&</span> <span class="n">compareIndexedMTime</span><span class="p">(</span><span class="n">KUrl</span><span class="p">(</span><span class="n">path</span><span class="p">),</span> <span class="n">QFileInfo</span><span class="p">(</span><span class="n">path</span><span class="p">).</span><span class="n">lastModified</span><span class="p">())</span> <span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Please move this check after the kdebug.
Of course I always prefer the one-exit design but the return is fine, too. :P</pre>
</div>
<br />
<p>- Sebastian</p>
<br />
<p>On January 27th, 2012, 10:35 a.m., Vishesh Handa wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Nepomuk, Alex Fiestas and Sebastian Trueg.</div>
<div>By Vishesh Handa.</div>
<p style="color: grey;"><i>Updated Jan. 27, 2012, 10:35 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This Filewatcher sends files for reindexing when it receives a WriteOnClose event from inotify. This event is generated whenever a file opened in write mode is closed. Even if they were no changes.
Programs like Amarok and KTorrent often open the files in write mode even when they don't make any changes. Which results in reindexing of those files.
For a graphical example - http://www.afiestas.org/nepomukReindexing.ogv</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">All the tests pass, and files are no longer reindexed when the song changes in Amarok.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>nepomuk/interfaces/org.kde.nepomuk.FileIndexer.xml <span style="color: grey">(24996f3)</span></li>
<li>nepomuk/services/fileindexer/fileindexer.h <span style="color: grey">(7133392)</span></li>
<li>nepomuk/services/fileindexer/fileindexer.cpp <span style="color: grey">(093c8da)</span></li>
<li>nepomuk/services/fileindexer/indexcleaner.cpp <span style="color: grey">(f90a0e0)</span></li>
<li>nepomuk/services/fileindexer/indexscheduler.h <span style="color: grey">(90757ce)</span></li>
<li>nepomuk/services/fileindexer/indexscheduler.cpp <span style="color: grey">(1690c05)</span></li>
<li>nepomuk/services/fileindexer/nepomukindexer.cpp <span style="color: grey">(ff981e6)</span></li>
<li>nepomuk/services/filewatch/nepomukfilewatch.cpp <span style="color: grey">(60550c2)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103794/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>