<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103259/">http://git.reviewboard.kde.org/r/103259/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Two things: 1. please add "strigi" as the review group, 2. please add comments into the code. Apart from that it looks ok to me - but it is really up to Jos to give the final ok.
Also it seems that Qt might need patching, too.</pre>
<br />
<p>- Sebastian</p>
<br />
<p>On November 26th, 2011, 9:45 p.m., Xuetian Weng wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Nepomuk.</div>
<div>By Xuetian Weng.</div>
<p style="color: grey;"><i>Updated Nov. 26, 2011, 9:45 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The upstream bug report, though unconfirmed.
More glibc 2.14 test result is welcome. (Tested on Chakra and Arch).
http://sourceware.org/bugzilla/show_bug.cgi?id=13439
UTF-16 endianness will be remember once glibc 2.14 iconv is called, which will cause QString toLocal8Bit behaviour incorrect if strigi resolve a big endian encoded UTF-16 string first on little endian (x86) machine. So this patch ignore the endian test provided by iconv and do it by hand.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Test on my machine, index no longer hangs.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=274251">274251</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>lib/endanalyzers/id3endanalyzer.cpp <span style="color: grey">(a3b33ae)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103259/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>