<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102994/">http://git.reviewboard.kde.org/r/102994/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Nepomuk and Strigi.</div>
<div>By Ignacio Serantes.</div>
<p style="color: grey;"><i>Updated Oct. 30, 2011, 10:43 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch solves a bug that prevented mp3 files with "disc number" tag being indexed. Code is based in "track number" code, and in the solution implemented in "flacendanalyzer.cpp", with the exception of the "found_track" flag because I think that is not necessary.
The error message displayed by nepomukserver was:
Soprano: "Invalid argument (1)": "<http://www.semanticdesktop.org/ontologies/2009/02/19/nmm#setNumber> has a rdfs:domain of <http://www.semanticdesktop.org/ontologies/2009/02/19/nmm#MusicPiece>. <_:c> only has the following types <http://www.semanticdesktop.org/ontologies/2009/02/19/nmm#MusicAlbum>, <http://www.w3.org/2000/01/rdf-schema#Resource>"</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Before applying the patch:
-Trying to index several mp3s with disc number tag: indexing fails
-Trying to index the same mp3s after disc number tag was removed: indexing works
After applying the patch:
-Trying to index several mp3s with disc number tag: indexing worked and proper value was set in nmm:setNumber</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>lib/endanalyzers/id3endanalyzer.h <span style="color: grey">(4d33740)</span></li>
<li>lib/endanalyzers/id3endanalyzer.cpp <span style="color: grey">(a3b33ae)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102994/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>