<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102128/">http://git.reviewboard.kde.org/r/102128/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Nepomuk and Sebastian Trueg.</div>
<div>By Vishesh Handa.</div>
<p style="color: grey;"><i>Updated Oct. 11, 2011, 10:11 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Addressed all of Sebastian's concerns, apart from the documentation.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">When SimpleResources are passed on to storeResources they are run through an identification process, so as to avoid duplicates. The resources which fail the identification process are then created.
It is nice to have a mapping of the SimpleResource uris and the uris that are finally pushed in the Nepomuk Repository.
I've tried for over 2 days to transfer the stupid QHash<QUrl,QUrl> over dbus. I've now given up and passed it as a QHash<QString,QString>.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested while using metadata sharing. The mappings are correctly returned.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>nepomuk/interfaces/org.kde.nepomuk.DataManagement.xml <span style="color: grey">(a10e3a5)</span></li>
<li>nepomuk/services/storage/datamanagementadaptor.h <span style="color: grey">(1ab4119)</span></li>
<li>nepomuk/services/fileindexer/indexer/nepomukindexwriter.cpp <span style="color: grey">(ce3cad7)</span></li>
<li>nepomuk/services/storage/datamanagementadaptor.cpp <span style="color: grey">(156d08c)</span></li>
<li>nepomuk/services/storage/datamanagementcommand.h <span style="color: grey">(1f06fe2)</span></li>
<li>nepomuk/services/storage/datamanagementmodel.h <span style="color: grey">(e5bbd70)</span></li>
<li>nepomuk/services/storage/datamanagementmodel.cpp <span style="color: grey">(d429973)</span></li>
<li>nepomuk/services/storage/lib/CMakeLists.txt <span style="color: grey">(ec33ba7)</span></li>
<li>nepomuk/services/storage/lib/datamanagement.h <span style="color: grey">(61ec4cc)</span></li>
<li>nepomuk/services/storage/lib/datamanagement.cpp <span style="color: grey">(106b289)</span></li>
<li>nepomuk/services/storage/lib/dbustypes.h <span style="color: grey">(900e219)</span></li>
<li>nepomuk/services/storage/lib/dbustypes.cpp <span style="color: grey">(27fd0f4)</span></li>
<li>nepomuk/services/storage/lib/simpleresourcegraph.h <span style="color: grey">(69143a6)</span></li>
<li>nepomuk/services/storage/lib/simpleresourcegraph.cpp <span style="color: grey">(4c5b221)</span></li>
<li>nepomuk/services/storage/lib/storeresourcesjob.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>nepomuk/services/storage/lib/storeresourcesjob.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>nepomuk/services/storage/test/asyncclientapitest.cpp <span style="color: grey">(628c23d)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102128/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>