<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102216/">http://git.reviewboard.kde.org/r/102216/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 998619b4e4879cc14418e8ee64af9b5dff872c42 by Sebastian Trueg to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On August 4th, 2011, 3:05 p.m., Sebastian Trueg wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Nepomuk and Strigi.</div>
<div>By Sebastian Trueg.</div>
<p style="color: grey;"><i>Updated Aug. 4, 2011, 3:05 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">A short while ago I introduced the new method AnalysisResult::finishIndexChild so clients can properly update the indexing status. I figured I would only have to call this method in analysers that afterwards continue to index the main file. However, it turns out that the problem also arises when other analysers are run after the one not calling finishIndexChild. This would for example result in a wrong depth for SHA1 checksums which would then be rejected by Nepomuk.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Indexing works properly with patch. Checksums are saved to Nepomuk again.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>lib/endanalyzers/arendanalyzer.cpp <span style="color: grey">(2e7c371)</span></li>
<li>lib/endanalyzers/bz2endanalyzer.cpp <span style="color: grey">(a4b4ba7)</span></li>
<li>lib/endanalyzers/cpioendanalyzer.cpp <span style="color: grey">(74e12a4)</span></li>
<li>lib/endanalyzers/gzipendanalyzer.cpp <span style="color: grey">(947579e)</span></li>
<li>lib/endanalyzers/lzmaendanalyzer.cpp <span style="color: grey">(4515434)</span></li>
<li>lib/endanalyzers/odfendanalyzer.cpp <span style="color: grey">(5227925)</span></li>
<li>lib/endanalyzers/oleendanalyzer.cpp <span style="color: grey">(7c2105b)</span></li>
<li>lib/endanalyzers/pdfendanalyzer.cpp <span style="color: grey">(a0e4111)</span></li>
<li>lib/endanalyzers/rpmendanalyzer.cpp <span style="color: grey">(fe248e7)</span></li>
<li>lib/endanalyzers/sdfendanalyzer.cpp <span style="color: grey">(bb0bbc4)</span></li>
<li>lib/endanalyzers/tarendanalyzer.cpp <span style="color: grey">(4601107)</span></li>
<li>lib/endanalyzers/zipendanalyzer.cpp <span style="color: grey">(1ab4d91)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102216/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>