<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101963/">http://git.reviewboard.kde.org/r/101963/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On July 28th, 2011, 9:25 a.m., <b>Sebastian Trueg</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Could you update this to be a review against kde-runtime instead?</pre>
</blockquote>
<p>On July 29th, 2011, 4:56 p.m., <b>Artem Serebriyskiy</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Not entirely. I can't move FindNepomuk to kde-runtime. But I can move the new cmake script. But what is wrong for it in beeing in kdelibs ? It is anyway optional include for now.</pre>
</blockquote>
<p>On July 29th, 2011, 6:41 p.m., <b>Sebastian Trueg</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">We cannot have a cmake script which depends on kde-runtime in kdelibs. That is simply not possible. And I don't think you need to change FindNepomuk.cmake. For now it is fone if developers simply include the new cmake macro manually. Once we move all of the DMS client to kdelibs - then we can also add it to FindNepomuk.cmake.</pre>
</blockquote>
<p>On July 30th, 2011, 9:28 a.m., <b>Artem Serebriyskiy</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ok. No problems to do this.
But don't blame me for asking - may be it is better to move DMS to kdelibs ? 4.7 is already released ;)
* And there is no "real" dependency - include is optional, find_program is optional too, so if you do pind_package(Nepomuk) without kde-runtime installed, there will be no error - simpleresource rcgen script will be simply not found and it will be ignored.
But, as I mention, I can easily do this very quickly if you think it is necessary.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I agree. Lets move the DMS lib to kdelibs. That way we can easily port nepomuklib to the DMS, instead of ugly DBus calls.</pre>
<br />
<p>- Vishesh</p>
<br />
<p>On July 24th, 2011, 8:27 a.m., Artem Serebriyskiy wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Nepomuk.</div>
<div>By Artem Serebriyskiy.</div>
<p style="color: grey;"><i>Updated July 24, 2011, 8:27 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch addes new cmake script to kdelibs that wraps calls to nepomuk_simpleresource_rcgen.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">On my system. Used in Nepomuk Web Extractor.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>cmake/modules/CMakeLists.txt <span style="color: grey">(65379db)</span></li>
<li>cmake/modules/FindNepomuk.cmake <span style="color: grey">(7307649)</span></li>
<li>cmake/modules/NepomukAddSimpleResourceClasses.cmake <span style="color: grey">(PRE-CREATION)</span></li>
<li>cmake/modules/NepomukMacros.cmake <span style="color: grey">(14acd2b)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101963/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>