<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/102128/">http://git.reviewboard.kde.org/r/102128/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I may know how to pass QHash<QUrl,QUrl> via DBus. Could you please delay commiting, I want to try to implement it and send it to you so changes to be submitted in one commit, instead of two. I will try to send it in the next 12 hours. Ok?</pre>
<br />
<p>- Artem</p>
<br />
<p>On July 29th, 2011, 9:04 a.m., Vishesh Handa wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Nepomuk and Sebastian Trueg.</div>
<div>By Vishesh Handa.</div>
<p style="color: grey;"><i>Updated July 29, 2011, 9:04 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">When SimpleResources are passed on to storeResources they are run through an identification process, so as to avoid duplicates. The resources which fail the identification process are then created.
It is nice to have a mapping of the SimpleResource uris and the uris that are finally pushed in the Nepomuk Repository.
I've tried for over 2 days to transfer the stupid QHash<QUrl,QUrl> over dbus. I've now given up and passed it as a QHash<QString,QString>.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested while using metadata sharing. The mappings are correctly returned.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>nepomuk/interfaces/org.kde.nepomuk.DataManagement.xml <span style="color: grey">(0172373)</span></li>
<li>nepomuk/services/storage/datamanagementadaptor.h <span style="color: grey">(05ef64c)</span></li>
<li>nepomuk/services/storage/datamanagementadaptor.cpp <span style="color: grey">(4ca8114)</span></li>
<li>nepomuk/services/storage/datamanagementcommand.h <span style="color: grey">(c970404)</span></li>
<li>nepomuk/services/storage/datamanagementmodel.h <span style="color: grey">(9722157)</span></li>
<li>nepomuk/services/storage/datamanagementmodel.cpp <span style="color: grey">(062cdcc)</span></li>
<li>nepomuk/services/storage/lib/CMakeLists.txt <span style="color: grey">(2189a7f)</span></li>
<li>nepomuk/services/storage/lib/datamanagement.h <span style="color: grey">(5b31603)</span></li>
<li>nepomuk/services/storage/lib/datamanagement.cpp <span style="color: grey">(9c570b0)</span></li>
<li>nepomuk/services/storage/lib/dbustypes.h <span style="color: grey">(900e219)</span></li>
<li>nepomuk/services/storage/lib/dbustypes.cpp <span style="color: grey">(27fd0f4)</span></li>
<li>nepomuk/services/storage/lib/simpleresourcegraph.h <span style="color: grey">(386b8c1)</span></li>
<li>nepomuk/services/storage/lib/simpleresourcegraph.cpp <span style="color: grey">(3bab264)</span></li>
<li>nepomuk/services/storage/lib/storeresourcesjob.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>nepomuk/services/storage/lib/storeresourcesjob.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>nepomuk/services/storage/test/asyncclientapitest.cpp <span style="color: grey">(c430f06)</span></li>
<li>nepomuk/services/strigi/indexer/nepomukindexwriter.cpp <span style="color: grey">(8164b69)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/102128/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>