<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/101741/">http://git.reviewboard.kde.org/r/101741/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is a bit messy for my taste. So please put it in a branch and we will fix it in there.</pre>
<br />
<p>- Sebastian</p>
<br />
<p>On June 24th, 2011, 11:09 a.m., Artem Serebriyskiy wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Nepomuk and Soprano.</div>
<div>By Artem Serebriyskiy.</div>
<p style="color: grey;"><i>Updated June 24, 2011, 11:09 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Port Raptor serializer to libraptor2 + provide test for serializers</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">There were no tests in soprano for serializers. So I wrote one( based on parsertest). This, unfortunately, means that it is not possible to rely on this test to detect if port to raptor2 is correct.
Nevertheless, evrything is compiling on my system and this new test is successfully passed.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>backends/redland/redlandqueryresult.cpp <span style="color: grey">(dbddcba)</span></li>
<li>cmake/modules/FindRaptor.cmake <span style="color: grey">(6347647)</span></li>
<li>parsers/raptor/CMakeLists.txt <span style="color: grey">(2adf527)</span></li>
<li>parsers/raptor/raptor-config.h.cmake <span style="color: grey">(dc35028)</span></li>
<li>parsers/raptor/raptorparser.h <span style="color: grey">(e6a7f99)</span></li>
<li>parsers/raptor/raptorparser.cpp <span style="color: grey">(0aabb73)</span></li>
<li>serializers/raptor/raptorserializer.h <span style="color: grey">(39037bb)</span></li>
<li>serializers/raptor/raptorserializer.cpp <span style="color: grey">(959f80a)</span></li>
<li>test/CMakeLists.txt <span style="color: grey">(a17805a)</span></li>
<li>test/serializetest.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>test/serializetest.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/101741/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>