<br><br><div class="gmail_quote">On Wed, May 26, 2010 at 3:13 PM, Sebastian Trüg <span dir="ltr"><<a href="mailto:trueg@kde.org">trueg@kde.org</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<div class="im">On 05/26/2010 10:08 AM, Vishesh Handa wrote:<br>
> > 3. When checking if the the m_kickoffUri is a nie:url for a resource.<br>
> > The nieUrl is assigned to be equal to the uri. This however gets fixed<br>
> > in the load(). And nieUrl isn't used anywhere, so it doesn't<br>
> matter that<br>
> > much.<br>
><br>
> I suppose you mean this part:<br>
><br>
> if( it.next() ) {<br>
> QUrl uri = it["r"].uri();<br>
> if( uri.isEmpty() ) {<br>
> m_uri = m_kickoffUri;<br>
> }<br>
> else {<br>
> m_uri = uri;<br>
> m_nieUrl = uri;<br>
> }<br>
><br>
> The last two lines. AFAICT this is perfectly fine since in the latter<br>
> case both nie:url and resource URI are equal.<br>
><br>
><br>
> I respectfully disagree. :)<br>
><br>
> The query used is this "select distinct ?r ?o where { { ?r nie:url <uri><br>
> . } UNION { <uri> ?p ?o . } } LIMIT 1". The case where ?r isn't empty<br>
> is when the <uri> contains the nie:url and therefore ?r will contain the<br>
> resource uri.<br>
<br>
</div>You are of course correct. It should be "m_nieUrl = m_kickoffUri"<br>
instead. Agreed?<br>
<br></blockquote><div><br>Yup. :)<br><br>If you get the time could you please look at my horrible merge patch?<br><br>Thanks<br>- Vishesh Handa <br><br></div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
Cheers,<br>
<font color="#888888">Sebastian<br>
</font></blockquote></div><br>