Hi Sebastian<br><br><div class="gmail_quote"><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
How to block signals:<br>
1. Use QObject::blockSignals()<br>
</blockquote><div><br>Didn't work! :-( I've seen the disconnect/reconnect approach being used successfully as well. There must be something special about this case. I'll check it out tom. <br><br></div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
* There is no real need to optimize the folder list in the filewatch<br>
service. StrigiServiceConfig already does that before giving the list to<br>
the IndexScheduler</blockquote><div> </div><div>I thought it's better to optimize it once before saving it rather than optimize it every time while loading. Anyway, I've removed the optimization code. It's now redundant. <br>
</div><div> </div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
* I think we need a better name than "restart". Maybe "ignore last<br>
config change" or something like that.<br></blockquote><div><br>I've changed it to "ignore changes". Is that okay?<br> </div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
* Any chance the config handling in IndexScheduler could be moved to<br>
StrigiServiceConfig? Just so config handling is restricted to the one class.<br></blockquote><div><br>Done.<br> <br></div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
* Now for the only critical use case: imagine filewatch changes the<br>
config, then the kcm changes the folders, and only then strigi gets to<br>
the config. I am not sure if that can even happen but if so strigi would<br>
ignore the new config. But I suppose this is very unlikely to happen or<br>
even impossible.<br></blockquote><div><br>The probability of this happening is very low. However I've edited KCM to make sure it doesn't occur.<br><br>I've modified the patch to remove auto adding of sub folders to indexed list as that is what everyone wanted. (I don't!)<br>
<br>- Vishesh Handa<br><br></div></div>