<br><div class="gmail_quote"><div>Hello Sebastian<br> <br></div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">While conceptually you are completely right I think it would be better<br>
to make the FileWatcher update the strigi config. FileWatcher is taking<br>
enough resources as it is by watching all the folders.<br></blockquote><div><br>I tried that, but then I required the StrigiServiceConfig class. So, I thought KInotify is more portable. But we don't want another resource hog! <br>
<br></div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
<div class="im">I thought about doing it this way, too. But then twice the mem is used<br></div>
and I figured watchingPath() and removePath() are not called very often.<br>
Thus, the mem savings would be preferable. I suppose...<br></blockquote><div><br>The memory saved wouldn't be much. But, watchingPath() is only called in FileWatch::addWatch before adding a watch. The moment I see a TODO: Optimize. I just have to try! :)<br>
</div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">Why do you think it should do this? After all, addWatch does also<br>
recurse into subdirs. Plus, we only stop watching a folder if it is<br>
removed. In that case the subfolders are of no interest anyway. :P<br>
<div class="im"><br></div></blockquote><div>True. But it doesn't seem logical. It serves the FileWatcher's purpose perfectly, but logically one would think removeWatch would just remove 1 watch. Plus, who in the world would be watching a subdir when they are already watching it's parent. Maybe we could add another function which removes the other watches?<br>
</div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">Only sibling? AFAIK the only problem is moving to a non-watched folder,<br>
i.e. a folder outside the home dir or any indexed folder.<br></blockquote><div><br>Yes. And my code only watches the indexed directories first parent (cd ..). Hence the sibling thing. It was just the first patch where I was fiddling around.<br>
<br>Btw, we need to do something about this. I have partitioned my hard disk, and they are mounted in the /media/ directory. The metadata mover just deletes the metadata. I was thinking about downloading the kernel's source code, and try to hack inotify, but then I've just compiled my kernel once in my life, and making modifications seems like a huge leap forward. :(<br>
<br></div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
Thus, it can be simplified a lot by removing all the dirwatch details<br>
and just keeping the slotMoved method. So in the end it is just one<br>
method. Maybe no need for a class. :P<br></blockquote><div><br>I was mainly using this class for testing kinotify, I just changed the name and slapped on a couple of functions. I thought it wouldn't be right for me to just state the problem without even trying to solve it. <br>
</div><div> </div><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;">
but I will see about making that public so we can collaborate. :)<br>
<br></blockquote><div>Please do. Trying to debug the strigiservice while filewatch keeps spewing out debug messages is quite, well not difficult, but distracting. <br><br><br>So, what do we do now? Should I try to integrate it into the filewatch service?<br>
<br>- Vishesh Handa<br><br>PS : I got an SVN account! :)<br><br></div></div>