[Nepomuk] Review Request: Add nfo:Audio type to riff analyzer
Vishesh Handa
handa.vish at gmail.com
Sat Aug 27 08:15:20 UTC 2011
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102336/
-----------------------------------------------------------
(Updated Aug. 27, 2011, 8:15 a.m.)
Review request for Nepomuk, Strigi, Jos van den Oever, and Sebastian Trueg.
Changes
-------
For AVI files - srth() is executed and then srtf().
Output -
rdfindexer How.I.Met.Your.Mother.S06E16.HDTV.XviD-LOL.\[VTV\].avi [0]
avih
srth
In audio: 0
strf
srth
In audio: 1
strf
For WAV files - Only strf. So, we need to add the type over there as well.
I should have tested the last patch.
Summary
-------
Add the required type. I'm not sure if I should be adding nfo:Audio or nfo:MusicPiece.
Diffs (updated)
-----
lib/endanalyzers/id3endanalyzer.cpp a3b33ae
plugins/eventplugins/riffeventanalyzer.cpp 69aa927
Diff: http://git.reviewboard.kde.org/r/102336/diff
Testing
-------
Works fine, and the files are getting indexed by Nepomuk as they have the correct type.
Thanks,
Vishesh
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/nepomuk/attachments/20110827/f4abe9f2/attachment-0001.html>
More information about the Nepomuk
mailing list