[Nepomuk] [PATCHES] QDBusServiceWatcher and Strigi

[Sebastian Trüg]

On 04/11/2010 10:24 PM, Vishesh Handa wrote:
> I've tested it out and it works fine. However I changed the code a
> little bit. I've added the /m_watcher->removeWatchedService(
> message().service() );/ to the slotServiceUnregistered function instead
> of the /unregisterSearchUrl/ function. It seems better this way.

It is more correct since one client could have multiple query urls
registered. Then if one was removed but the other was still active we
would still need to monitor that client.
However, doing it in slotServiceUnregistered, while it works perfectly,
is not 100% perfect since this way we also monitor clients that had a
registered query but then unregistered it but are still running.
So the perfect solution would be to do it in unregisterSearchUrl but
only if this service has no values in the hash anymore. Right?

> Please commit the patches. :-) And, Sebastian, thanks for excellent
> instructions! I'll do the rest later (I will do them! I call dibs.)

ok, great. :)

Cheers,
Sebastian