<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108165/">http://git.reviewboard.kde.org/r/108165/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/108165/diff/3/?file=104581#file104581line1097" style="color: black; font-weight: bold; text-decoration: underline;">src/plugins/platforms/android/src/androidjnimain.cpp</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">static void onNewIntent(JNIEnv * env, jobject thiz, jstring url) {</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">1097</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">const</span> <span class="kt">char</span> <span class="o">*</span><span class="n">nativeString</span> <span class="o">=</span> <span class="n">env</span><span class="o">-></span><span class="n">GetStringUTFChars</span><span class="p">(</span><span class="n">url</span><span class="p">,</span> <span class="mi">0</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Sorry, I just seen another one.
Please change the following three lines to:
const jchar * jstr = env->GetStringChars(url, 0);
QUrl qurl(QString((const QChar*)jstr, env->GetStringLength(url)));
env->ReleaseStringChars(url, jstr);
This way you are avoiding two useless conversions:
UTF16 to UTF8 and UTF8 to UTF16
</pre>
</div>
<br />
<p>- BogDan</p>
<br />
<p>On January 4th, 2013, 4:39 p.m., Micke Prag wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Necessitas.</div>
<div>By Micke Prag.</div>
<p style="color: grey;"><i>Updated Jan. 4, 2013, 4:39 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch makes it possible to call an Android/Qt application using Intents. The data (url) will be forwarded to the QApplication as a QFileOpenEvent</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested on Cube U30GT</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/android/jar/src/org/kde/necessitas/industrius/QtActivityDelegate.java <span style="color: grey">(0e147ac)</span></li>
<li>src/android/jar/src/org/kde/necessitas/industrius/QtNative.java <span style="color: grey">(0c0707f)</span></li>
<li>src/android/jar_4/src/org/kde/necessitas/industrius/QtNative.java <span style="color: grey">(2c8dd8b)</span></li>
<li>src/plugins/platforms/android/src/androidjnimain.cpp <span style="color: grey">(6b5229a)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108165/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>