<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105052/">http://git.reviewboard.kde.org/r/105052/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Necessitas.</div>
<div>By Gabi Julien.</div>
<p style="color: grey;"><i>Updated May 29, 2012, 4:05 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description (updated)</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">As discussed on the mailing list[1], this is an implementation of QMediaPlayer using Android's MediaPlayer and MediaMetadataRetriever classes. This patch is only the qt-mobility part. Another patch on android-lighthouse is needed.
[1] http://mail.kde.org/pipermail/necessitas-devel/2012-May/000916.html </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Using Asus's Transformer Prime TF 201
1. 1080p h264 video on Android 4.0.3.
2. mp3 music without surfaces.
3. Various tests involving volume, seeking, duration,... using the QMediaPlayer API.
My tests on Android 2.3.1 failed so far because a second hardware accelerated surface is needed. Also, the MediaMetadataRetriever is not available before API 10. The good news is that music playback should still work.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>plugins/multimedia/android/mediaplayer/jnienvcontext.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/multimedia/android/mediaplayer/jnienvcontext.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/multimedia/android/mediaplayer/jnimanager.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/multimedia/android/mediaplayer/jnimanager.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/multimedia/android/mediaplayer/mediaPlayerJNI.h <span style="color: grey">(a77cec4)</span></li>
<li>plugins/multimedia/android/mediaplayer/mediaPlayerJNI.cpp <span style="color: grey">(110a6ac)</span></li>
<li>plugins/multimedia/android/mediaplayer/mediaplayer.pro <span style="color: grey">(9b8d64d)</span></li>
<li>plugins/multimedia/android/mediaplayer/qandroidmetadatacontrol.cpp <span style="color: grey">(6dd2f4a)</span></li>
<li>plugins/multimedia/android/mediaplayer/qandroidplayercontrol.cpp <span style="color: grey">(a519ece)</span></li>
<li>plugins/multimedia/android/mediaplayer/qandroidplayersession.h <span style="color: grey">(7efffba)</span></li>
<li>plugins/multimedia/android/mediaplayer/qandroidplayersession.cpp <span style="color: grey">(612ee2d)</span></li>
<li>plugins/multimedia/android/mediaplayer/qandroidvideothread.h <span style="color: grey">(fb4660d)</span></li>
<li>plugins/multimedia/android/mediaplayer/qandroidvideothread.cpp <span style="color: grey">(fb7f0a1)</span></li>
<li>plugins/multimedia/android/mediaplayer/qandroidvideowidget.cpp <span style="color: grey">(cce50a4)</span></li>
<li>plugins/multimedia/android/mediaplayer/qtmediametadataretrieverjni.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/multimedia/android/mediaplayer/qtmediametadataretrieverjni.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/multimedia/android/mediaplayer/qtmediaplayerjni.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>plugins/multimedia/android/mediaplayer/qtmediaplayerjni.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105052/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>