<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/104450/">http://git.reviewboard.kde.org/r/104450/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 4th, 2012, 6:39 p.m., <b>BogDan Vatra</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Please run the tests (android/runtests.pl) after your do the changes.
</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I tried running the tests, but quadruplor seems to be outdated, i.e. not even meant to work with alpha3. Maybe I'm wrong. But the plugin (libandroid-9.so) is registering native functions for classes that exist in the JAR but don't exist in quadruplor (which doesn't use the JAR at all.) Specifically, QtNativeInputConnection. This causes dalvik to abort the process.
Does quadruplor need to be updated somehow? IMHO, it looks like it's going to be difficult to maintain in its current state. I updated it (and runtests.pl) to play nice with my changes to the plugin, but as for this problem I just described, I'm not sure what you want to do.</pre>
<br />
<p>- Tyler</p>
<br />
<p>On April 7th, 2012, 7:38 a.m., Tyler Mandry wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Necessitas and BogDan Vatra.</div>
<div>By Tyler Mandry.</div>
<p style="color: grey;"><i>Updated April 7, 2012, 7:38 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Allows interaction between user Java and user C/C++ (JNI) code, by loading the user's code in the main class loader.
SF.net bug: 140
Details
-------
This removes everything in src/android/cpp. qtmain_android.cpp is no more and is now integrated into src/plugins/platforms/android/src/androidjnimain.cpp. It seemed fitting to integrate startQtApp() into the same file as pauseQtApp() and resumeQtApp(). (Additionally this removes redundant copied code, and simplifies how necessitas projects work and are built.)
Compatibility
-------------
New library should be fully compatible with apps *already built* with old versions (before this change.) To build against the new library, existing projects simply need to update their QtActivity.java file.
Other
-----
This doesn't support using JNI with bundled libs. We have to be careful to load certain bundled libs (maybe only the plugin .so) in the delegate class loader, so I could break certain apps by making such a switch. Need a way to categorize the type of bundled lib, in order to decide which class loader to use.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested on a Galaxy Nexus and a Nexus One.
New libraries run both old and new apps.
New libraries support JNI interaction.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>android/quadruplor/src/org/kde/necessitas/industrius/QtActivity.java <span style="color: grey">(4ecf3c8)</span></li>
<li>android/quadruplor/src/org/kde/necessitas/industrius/QtNative.java <span style="color: grey">(3e82ce6)</span></li>
<li>android/runtests.pl <span style="color: grey">(2e438fd)</span></li>
<li>mkspecs/android-g++/qmake.conf <span style="color: grey">(5904ea1)</span></li>
<li>mkspecs/features/qt.prf <span style="color: grey">(a254437)</span></li>
<li>src/android/cpp/qtmain_android.cpp <span style="color: grey">(e5f5fc8)</span></li>
<li>src/android/jar/src/org/kde/necessitas/industrius/QtActivityDelegate.java <span style="color: grey">(85add90)</span></li>
<li>src/android/jar/src/org/kde/necessitas/industrius/QtNative.java <span style="color: grey">(24ebb5b)</span></li>
<li>src/android/java/src/org/kde/necessitas/origo/QtActivity.java <span style="color: grey">(fcbccef)</span></li>
<li>src/plugins/platforms/android/src/androidjnimain.cpp <span style="color: grey">(c8a5001)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/104450/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>