<html><body><div style="color:#000; background-color:#fff; font-family:times new roman, new york, times, serif;font-size:12pt"><div><span>Hi Daniel,</span></div><div><br><span></span></div><div><span>I check your patches almost all of them are ok, the last one I think is a misunderstanding, </span>AndroidDeployConfiguration doesn't have any configuration which needs to be saved, I'll change it. <span> </span></div><div><span>I also tried to merge master branch but I had some problems, it seems you've made some changes to debugging plugin, so, I'll try tomorrow (night) to fix them and to test QtCreator then I'll push the changes.</span></div><div><br><span></span></div><div><span>Thank you !</span></div><div><br><span></span></div><div><span>Cheers,</span></div><div><span>BogDan.</span></div><div><br><blockquote style="border-left: 2px solid rgb(16, 16, 255); margin-left: 5px; padding-left: 5px;"><div style="font-family: times new roman, new york,
times, serif; font-size: 12pt;"><div style="font-family: times new roman, new york, times, serif; font-size: 12pt;"><font face="Arial" size="2"><hr size="1"><b><span style="font-weight:bold;">From:</span></b> Daniel Teske <daniel.teske@nokia.com><br><b><span style="font-weight: bold;">To:</span></b> necessitas-devel@kde.org<br><b><span style="font-weight: bold;">Sent:</span></b> Thursday, September 15, 2011 4:52 PM<br><b><span style="font-weight: bold;">Subject:</span></b> Re: More patches<br></font><br>Hi,<br><br>some more patches for your review.<br><br>0001:<br>Returning mobile from the targetFeatures essentially just switches for which <br>new project templates the target is enabled by default. The Qt Quick <br>Application Wizard preselects all mobile targets, whereas the qt gui wizard <br>enables desktop targets. As such returning mobile is probably a better choice.<br><br>0002:<br>There have been a few chanegs to the TargetFactory since the
<br>AndroidTargetFactory was written, I have removed some no longer needed <br>virtuals and added a missed one.<br><br>0003:<br>As part of the RemoteLinux refactoring we moved the DeployConfigurationFactory <br>from the being attached to the target to the object pool. This patch makes the <br>same change to the Android DeployConfigurationFactory.<br><br>0004:<br>Just a unused member<br><br>0005:<br>This adds a AndroidDeployConfiguration class and readds save and restore code <br>to the AndroidDeployStep. Thus saving and restoring the settings for that step <br>now works for me.<br><br>daniel<br><br>_______________________________________________<br>Necessitas-devel mailing list<br><a ymailto="mailto:Necessitas-devel@kde.org" href="mailto:Necessitas-devel@kde.org">Necessitas-devel@kde.org</a><br><a href="https://mail.kde.org/mailman/listinfo/necessitas-devel"
target="_blank">https://mail.kde.org/mailman/listinfo/necessitas-devel</a><br><br><br></div></div></blockquote></div></div></body></html>