<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113523/">http://git.reviewboard.kde.org/r/113523/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">One small issue then I'm fine with this. KGraphViewer can be fixed/implemented later on as it's not really functional now.</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/113523/diff/2/?file=208909#file208909line461" style="color: black; font-weight: bold; text-decoration: underline;">app/mainwindow.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void MainWindow::settingsChanged()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">340</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">ParseWorker</span><span class="o">*</span> <span class="n">parseWorker</span> <span class="o">=</span> <span class="n">m_documentsParseWorkers</span><span class="p">.</span><span class="n">value</span><span class="p">(</span><span class="n">currentDocument</span><span class="p">());</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">you can use .take() here, which then obsoletes the call to .remove later on.</pre>
</div>
<br />
<p>- Milian Wolff</p>
<br />
<p>On November 3rd, 2013, 8:16 p.m. UTC, Arnold Dumas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Massif Visualizer.</div>
<div>By Arnold Dumas.</div>
<p style="color: grey;"><i>Updated Nov. 3, 2013, 8:16 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
massif-visualizer
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">All the former logic of creating the charts, the legend ... etc is now contained in the MassifDocumentWidget.
This widget is instanciated by the top-most tab widget. When the active tab changes, the massifDocumentChanged slot is called.
Some actions are enabled/disabled regarding of the situation. I noticed no particular bug or misbehavior when testing.
One more thing needs to be done: parallel file loading using ThreadWeaver.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>app/CMakeLists.txt <span style="color: grey">(31290f6)</span></li>
<li>app/documentwidget.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>app/documentwidget.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>app/main.cpp <span style="color: grey">(be938b4)</span></li>
<li>app/mainwindow.h <span style="color: grey">(2acc6a8)</span></li>
<li>app/mainwindow.cpp <span style="color: grey">(b33ff60)</span></li>
<li>app/mainwindow.ui <span style="color: grey">(8ac4119)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113523/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>