<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/113523/">http://git.reviewboard.kde.org/r/113523/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Massif Visualizer.</div>
<div>By Arnold Dumas.</div>
<p style="color: grey;"><i>Updated Nov. 3, 2013, 8:16 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">There is still one minor issue with this new patch but I first would like to find an agreement on the design first. Thus It will then be possible to fix the remainings bugs.
Instead of using ThreadWeaver, wich doesn't work, at least for me, I've used "raw" ParseWorker and QThreads. All the signals & slots mapping is done manually but it works fine so far. As far as I know, the design if I had use ThreadWeaver would have been the same. Hence It should no be too hard to move to ThreadWeaver later on.
Plus I've moved allmost all the code related to kgraphviewer in the DocumentWidget class. It should work but I didn't test is so far as I'm unable to compile kgraphviewer:master.
I hope this patch will fullfil your ideas about how multiple document interface should be designed and implemented. ;)</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
massif-visualizer
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">All the former logic of creating the charts, the legend ... etc is now contained in the MassifDocumentWidget.
This widget is instanciated by the top-most tab widget. When the active tab changes, the massifDocumentChanged slot is called.
Some actions are enabled/disabled regarding of the situation. I noticed no particular bug or misbehavior when testing.
One more thing needs to be done: parallel file loading using ThreadWeaver.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>app/CMakeLists.txt <span style="color: grey">(31290f6)</span></li>
<li>app/documentwidget.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>app/documentwidget.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>app/main.cpp <span style="color: grey">(be938b4)</span></li>
<li>app/mainwindow.h <span style="color: grey">(2acc6a8)</span></li>
<li>app/mainwindow.cpp <span style="color: grey">(b33ff60)</span></li>
<li>app/mainwindow.ui <span style="color: grey">(8ac4119)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/113523/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>