<div dir="ltr"><div dir="ltr"><div>Hi
Torsten,</div><div></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">Le dim. 2 août 2020 à 15:23, Torsten Rahn <<a href="mailto:tackat@t-online.de">tackat@t-online.de</a>> a écrit :<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div><p style="margin:0px"><span style="font-family:arial,helvetica,sans-serif;font-size:10pt;color:rgb(0,0,0);text-decoration:none"> </span></p>
<div>
<div dir="ltr">
<div>Hi Johnny,</div>
<div> </div>
<div>> It now builds correctly on the KDE build system: <a href="https://build.kde.org/view/OS%20-%20Windows/job/Applications/job/marble/" target="_blank">https://build.kde.org/view/OS%20-%20Windows/job/Applications/job/marble/</a></div>
<div> </div>
<div>> Next step is to update the Craft package that is used to build the installer: <a href="https://invent.kde.org/packaging/craft-blueprints-kde/-/blob/master/kde/applications/marble/marble.py" target="_blank">https://invent.kde.org/packaging/craft-blueprints-kde/-/blob/master/kde/applications/marble/marble.py</a></div>
<div> </div>
<div>> I have some questions regarding the package:</div>
<div>> * Which executable should be run? marble or marble-qt?</div>
<div> </div>
<div><span style="font-family:arial,helvetica,sans-serif;font-size:10pt;color:rgb(0,0,0);text-decoration:none"><span style="font-family:arial,helvetica,sans-serif;font-size:10pt;color:rgb(0,0,0);text-decoration:none">The preferred version for Windows would be marble-qt. In terms of functionality both versions are equivalent however marble-qt has less dependencies and hence results in a much smaller install package.</span></span></div>
<div> </div></div></div></div></blockquote><div><br></div><div>Ok, thank you!<br></div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div><div><div dir="ltr">
<div>> * there is a conflict where the plugins are installed with the Craft tool. For now, Craft moves all files under plugins/ inside the bin/ folder</div>
<div>> (this is because Qt plugins are installed in plugins and Craft made the choice to move all files under this folder inside bin/:</div>
<div>> https://<i>invent</i>.<a href="http://kde.org/packaging/craft/-/blob/master/bin/Packager/CollectionPackagerBase.py#L304" target="_blank">kde.org/packaging/craft/-/blob/master/bin/Packager/CollectionPackagerBase.py#L304</a>).</div>
<div> </div>
<div><span style="font-family:arial,helvetica,sans-serif;font-size:10pt;color:rgb(0,0,0);text-decoration:none"><span style="font-family:arial,helvetica,sans-serif;font-size:10pt;color:rgb(0,0,0);text-decoration:none">I guess this problem wouldn't occur for marble-qt where Marble should end up in its own directory under "C:\Programs"</span></span></div>
<div></div></div></div></div></blockquote><div><br></div><div>I may have been too quick on the explanation.</div><div>When compiling Marble, it compiles its plugins under the plugins/ folder (this is where we ask cmake to install it: <a href="https://invent.kde.org/education/marble/-/blob/master/CMakeLists.txt#L188">https://invent.kde.org/education/marble/-/blob/master/CMakeLists.txt#L188</a>).</div><div>When deploying the application using Craft, Craft first copies all of the Qt plugins inside the same plugins/ folder and then moves the whole folder to bin/ (which is where we installed the executable).</div><div>All of this is then installed to "C:\Programs".</div><div>So, instead of having:</div><div>C:\Programs\Marble\</div><div> bin\
marble-qt.exe
</div><div> plugins\marble-plugin.dll</div><div>we currently have:
<div>C:\Programs\Marble\</div><div> bin\marble-qt.exe</div><div> marble-plugin.dll
</div>
</div><div><br></div><div>Is it ok to install the plugins inside the same folder as marble-qt.exe? Or should I open a bug on Craft project to be more clean on which folder they copy the qt plugins?<br></div><div><br></div><div>Thank you,</div><div><br></div><div>Johnny</div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex"><div><div><div dir="ltr"><div> </div>
<div><span style="font-family:arial,helvetica,sans-serif;font-size:10pt;color:rgb(0,0,0);text-decoration:none"><span style="font-family:arial,helvetica,sans-serif;font-size:10pt;color:rgb(0,0,0);text-decoration:none"><span style="font-family:arial,helvetica,sans-serif;font-size:10pt;color:rgb(0,0,0);text-decoration:none"><span style="font-family:arial,helvetica,sans-serif;font-size:10pt;color:rgb(0,0,0);text-decoration:none">Best regards</span></span></span></span></div>
<div><span style="font-family:arial,helvetica,sans-serif;font-size:10pt;color:rgb(0,0,0);text-decoration:none"><span style="font-family:arial,helvetica,sans-serif;font-size:10pt;color:rgb(0,0,0);text-decoration:none"><span style="font-family:arial,helvetica,sans-serif;font-size:10pt;color:rgb(0,0,0);text-decoration:none"><span style="font-family:arial,helvetica,sans-serif;font-size:10pt;color:rgb(0,0,0);text-decoration:none"><span style="font-family:arial,helvetica,sans-serif;font-size:10pt;color:rgb(0,0,0);text-decoration:none">Torsten</span></span></span></span></span></div>
<div> </div>
<div>> I will ask if we can do a more selective move. The code where we handle the plugins path is OS-dependant on Marble</div>
<div>> but I guess it would still make sense to have them in a plugins/ folder.</div>
<div> </div>
<div>Thank you,</div>
<div> </div>
<div>Johnny</div>
</div>
</div></div></blockquote></div></div>