<table><tr><td style="">rahn added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D19329">View Revision</a></tr></table><br /><div><div><p>apart from the Boolean issue this looks good to me and can be submitted.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D19329#inline-107918">View Inline</a><span style="color: #4b4d51; font-weight: bold;">GeoDataCoordinates.h:392</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span class="err">*/</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span class="n">QString</span> <span class="n">toString</span><span class="p">(</span> <span class="n">GeoDataCoordinates</span><span style="color: #aa2211">::</span><span class="n">Notation</span> <span class="n">notation</span><span class="p">,</span> <span style="color: #aa4000">int</span> <span class="n">precision</span> <span style="color: #aa2211">=</span> <span style="color: #aa2211">-</span><span style="color: #601200">1</span> <span class="p">)</span> <span style="color: #aa4000">const</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">QString</span> <span class="n">toString</span><span class="p">(</span> <span class="n">GeoDataCoordinates</span><span style="color: #aa2211">::</span><span class="n">Notation</span> <span class="n">notation</span><span class="p">,</span> <span style="color: #aa4000">int</span> <span class="n">precision</span> <span style="color: #aa2211">=</span> <span style="color: #aa2211">-</span><span style="color: #601200">1<span class="bright"></span></span><span class="bright"></span><span class="p"><span class="bright">,</span></span><span class="bright"> </span><span style="color: #aa4000"><span class="bright">bool</span></span><span class="bright"> </span><span class="n"><span class="bright">orderLatLon</span></span><span class="bright"> </span><span style="color: #aa2211"><span class="bright">=</span></span><span class="bright"> </span><span style="color: #304a96"><span class="bright">false</span></span> <span class="p">)</span> <span style="color: #aa4000">const</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">such booleans as parameters always look dull (<a href="https://ariya.io/2011/08/hall-of-api-shame-boolean-trap" class="remarkup-link" target="_blank" rel="noreferrer">https://ariya.io/2011/08/hall-of-api-shame-boolean-trap</a>). What about using an enum instead ?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R34 Marble</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D19329">https://phabricator.kde.org/D19329</a></div></div><br /><div><strong>To: </strong>mkoller, Marble: General, rahn, nienhueser<br /><strong>Cc: </strong>marble-devel, kde-edu, torhamzed, jalvarez, mnafees, shentey, chaz6, dkolozsvari, narvaez, cmihalache, rahn, apol, nienhueser<br /></div>