<table><tr><td style="">dkolozsvari created this revision.<br />dkolozsvari added reviewers: nienhueser, rahn.<br />dkolozsvari added a subscriber: Marble.<br />dkolozsvari set the repository for this revision to rMARBLE Marble.<br />dkolozsvari added a project: Marble.</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D2444" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>With the introduction of batymetry polygons I realized that the parsing and cutting of polygons was working on the outer boundary of the polygon, the inner rings were left out.</p>
<p>This patch aims to fix that, though there are some issues with this approach or I'm just missing something. When a bathymetry polygon with some inner rings is cut and then the tile loaded into Marble, the inner rings are not getting rendered, though they are there in the file.</p></div></div><br /><div><strong>TEST PLAN</strong><div><p>Cutting to level 5 tiny_planet_5.1.osm and then checking tile 5/14/12 <a href="https://phabricator.kde.org/F257923" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;" rel="noreferrer">F257923: 12.osm</a> we can clearly see that even though there are lots of inner rings in the file, and the file's size is >500KB(that's pretty huge for a level 5 tile), there are barely some nodes and polygons rendered.</p>
<p><a href="https://phabricator.kde.org/F257922" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;" rel="noreferrer">F257922: Screenshot_20160815_081601.png</a></p></div></div><br /><div><strong>REPOSITORY</strong><div><div>rMARBLE Marble</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D2444" rel="noreferrer">https://phabricator.kde.org/D2444</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>tools/osm-simplify/TinyPlanetProcessor.cpp<br />
tools/osm-simplify/TinyPlanetProcessor.h</div></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>dkolozsvari, nienhueser, rahn<br /><strong>Cc: </strong>Marble, shentey, chaz6, dkolozsvari, cmihalache, rahn, nienhueser, marble-devel<br /></div>