
<table><tr><td style="">kossebau created this revision.<br />kossebau added reviewers: Marble, rahn, nienhueser.</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D2309" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>REVISION SUMMARY</strong><div><p>Using generate_export_header instead manually written export headers<br />

should improve coverage across platforms.</p>


<p>Size of stripped libmarblewidget-qt5 reduced on Linux<br />

e.g. from 11077592 to 7889848</p>


<p>Also removing methods which were deprecated for some time:</p>


<ul class="remarkup-list">

<li class="remarkup-list-item">AbstractDataPluginModel::downloadItemData() in 2012</li>

<li class="remarkup-list-item">GeoDataPlacemark::setCoordinate(GeoDataPoint) in 2012</li>

<li class="remarkup-list-item">ViewportParams::centerCoordinates() in 2011</li>

</ul></div></div><br /><div><strong>REPOSITORY</strong><div><div>rMARBLE Marble</div></div></div><br /><div><strong>BRANCH</strong><div><div>useGenerateExportHeader</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D2309" rel="noreferrer">https://phabricator.kde.org/D2309</a></div></div><br /><div><strong>AFFECTED FILES</strong><div><div>CMakeLists.txt<br />

src/lib/astro/CMakeLists.txt<br />

src/lib/marble/AbstractDataPluginModel.cpp<br />

src/lib/marble/AbstractDataPluginModel.h<br />

src/lib/marble/AbstractFloatItem.h<br />

src/lib/marble/CMakeLists.txt<br />

src/lib/marble/MarbleDBusInterface.h<br />

src/lib/marble/Planet.h<br />

src/lib/marble/Quaternion.h<br />

src/lib/marble/StyleBuilder.h<br />

src/lib/marble/ViewportParams.cpp<br />

src/lib/marble/ViewportParams.h<br />

src/lib/marble/declarative/CMakeLists.txt<br />

src/lib/marble/declarative/marble_declarative_export.h<br />

src/lib/marble/geodata/data/GeoDataContainer.h<br />

src/lib/marble/geodata/data/GeoDataPlacemark.cpp<br />

src/lib/marble/geodata/data/GeoDataPlacemark.h<br />

src/lib/marble/geodata/geodata_export.h<br />

src/lib/marble/marble_export.h<br />

src/lib/marble/routing/instructions/RoutingPoint.h<br />

src/plugins/positionprovider/geoclue/GeoCute/CMakeLists.txt<br />

tools/constellations2kml/CMakeLists.txt<br />

tools/dateline/CMakeLists.txt<br />

tools/kml2cache/CMakeLists.txt<br />

tools/kml2kml/CMakeLists.txt<br />

tools/mapreproject/CMakeLists.txt<br />

tools/maptheme-previewimage/CMakeLists.txt<br />

tools/osm-addresses/CMakeLists.txt<br />

tools/osm-simplify/CMakeLists.txt<br />

tools/osm-sisyphus/CMakeLists.txt<br />

tools/poly2kml/CMakeLists.txt<br />

tools/routing-instructions/CMakeLists.txt<br />

tools/shp2pn2/CMakeLists.txt<br />

tools/tilecreator-srtm2/CMakeLists.txt<br />

tools/tilecreator/CMakeLists.txt</div></div></div><br /><div><strong>EMAIL PREFERENCES</strong><div><a href="https://phabricator.kde.org/settings/panel/emailpreferences/" rel="noreferrer">https://phabricator.kde.org/settings/panel/emailpreferences/</a></div></div><br /><div><strong>To: </strong>kossebau, Marble, rahn, nienhueser<br /><strong>Cc: </strong>marble-devel<br /></div>