<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126729/">https://git.reviewboard.kde.org/r/126729/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been discarded.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Marble.</div>
<div>By Akshat Tandon.</div>
<p style="color: grey;"><i>Updated Jan. 13, 2016, 8:11 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=345919">345919</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Bug 345919 - Bookmark icons use absolute paths in any case
https://bugs.kde.org/show_bug.cgi?id=345919</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Feature
A new dialog added which allows a user to select one of the standard icons for his bookmark.All the predefined icons are in qrc folder qrc:/marble/bookmarks/. Apart from this the user can also use a custom icon for the bookmark.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Usage:
Choose Add a new Bookmark/ Edit a bookmark.
Click on the button which displays the icon.
A new dialog is created using which one of the icons can be choosen.
Click on 'Custom' button if a custom icon is to be choosen.
Select the appropriate icon and click on 'OK'.
Click on 'Cancel' if you want the previous icon to remain unchanged.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/lib/marble/CMakeLists.txt <span style="color: grey">(42fe56f)</span></li>
<li>src/lib/marble/IconChooserDialog.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/IconChooserDialog.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/IconChooserDialog.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/IconChooserModel.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/IconChooserModel.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/PlacemarkEditHeader.cpp <span style="color: grey">(893d051)</span></li>
<li>src/lib/marble/libmarble.qrc <span style="color: grey">(f30e887)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126729/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/01/12/8d98c947-ad3c-4f44-9c13-e0517352ec21__bookmark.png">Bookmark icon chooser dialog.</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>