<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125922/">https://git.reviewboard.kde.org/r/125922/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On November 3rd, 2015, 6:30 vorm. UTC, <b>Dennis Nienhüser</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">could this be solved by draw order also? Seems much easier to me.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">But wouldn't it look strange if the cursor disappeared <em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">behind</em> the popup? I think we even had that at one point and it looked broken.</p></pre>
<br />
<p>- Torsten</p>
<br />
<p>On November 2nd, 2015, 5:28 nachm. UTC, Imran Tatriev wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Marble.</div>
<div>By Imran Tatriev.</div>
<p style="color: grey;"><i>Updated Nov. 2, 2015, 5:28 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Fix crosshairs overlay PopupItem when reading the text.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Crosshairs overlay web-popup window from wikipedia and "interrupts" the reading. I've decided to automatically hide it when web-popup is open and automatically return to previous state when popup is closed.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">You can see before/after screenshots down below.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/lib/marble/PopupItem.h <span style="color: grey">(56fd7c0d11fb304adcaa546696a64d96ac0e007c)</span></li>
<li>src/lib/marble/layers/PopupLayer.h <span style="color: grey">(1ed58bad3de9681150ae88fe65005be7c6a68f83)</span></li>
<li>src/lib/marble/layers/PopupLayer.cpp <span style="color: grey">(8d8af29ab499f197321bd1feb836b5b84d2060ac)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125922/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/11/02/3fdaf3ee-441e-421c-9706-35819e371813__before.png">How it looked before</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/11/02/9b53bb43-8165-46ea-9824-49b91f64dec6__after.png">How it looks right now</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>