<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125011/">https://git.reviewboard.kde.org/r/125011/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Marble.</div>
<div>By Dāvis Mosāns.</div>
<p style="color: grey;"><i>Updated Sept. 19, 2015, 1:47 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Submitted with commit 489028c7c710a8119ac9075188acb69d6402179f by D?vis Mos?ns to branch master.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">QFont accepts QString which can't be casted to char * when QT_NO_CAST_FROM_ASCII is used.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">And it caused libkgeomap compile failure
In file included from /usr/include/qt/QtCore/qbytearray.h:680:0,
from /usr/include/qt/QtCore/qvariant.h:38,
from /usr/include/qt/QtCore/qabstractitemmodel.h:37,
from /usr/include/qt/QtCore/QModelIndex:1,
from /mnt/KDE/kde/kdegraphics/libs/libkgeomap/src/backend_map.h:34,
from /mnt/KDE/kde/kdegraphics/libs/libkgeomap/src/backend_map_marble.h:34,
from /mnt/KDE/kde/kdegraphics/libs/libkgeomap/src/backend_map_marble.cpp:29:
/usr/include/qt/QtCore/qstring.h:771:5: error: ‘QString::QString(const char<em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">)’ is private
QString(const char </em>ch);
^
In file included from /mnt/KDE/kde/kdegraphics/libs/libkgeomap/src/backend_map_marble.cpp:46:0:
/usr/include/marble/GeoPainter.h:312:101: error: within this context
const QColor& labelcolor = Qt::black, const QFont& labelFont = QFont("Arial"));
^
src/CMakeFiles/KF5KGeoMap.dir/build.make:518: recipe for target 'src/CMakeFiles/KF5KGeoMap.dir/backend_map_marble.cpp.o' failed</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Compiles and libkgeomap compiles too</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/lib/marble/AbstractFloatItem.cpp <span style="color: grey">(7c380f17edc4cce7908836afe76d86136c0d2312)</span></li>
<li>src/lib/marble/GeoPainter.h <span style="color: grey">(47b15cd0d7ed05c1a65f8bf1e3e8ce9675dae482)</span></li>
<li>src/lib/marble/LayerManager.cpp <span style="color: grey">(4c946d39d4a8899d4d5f243f59dec0cd700c64d0)</span></li>
<li>src/lib/marble/geodata/data/GeoDataFeature.cpp <span style="color: grey">(6099425886020b0683ee7ab0a1654747d02a105c)</span></li>
<li>src/lib/marble/geodata/data/GeoDataFeature_p.h <span style="color: grey">(b84bb56c631305b0d743997602f262b3ac18ba78)</span></li>
<li>src/lib/marble/geodata/data/GeoDataLabelStyle.cpp <span style="color: grey">(11f37ffe7a8162799ce3738342a97492d13eab37)</span></li>
<li>src/lib/marble/layers/FpsLayer.cpp <span style="color: grey">(7b78a9def5b1dab9f24dd9c0c715ad4c6f24ed97)</span></li>
<li>src/plasmoid/worldclock.cpp <span style="color: grey">(7b60228c57cf5946a6e3764f9f93085102a52f30)</span></li>
<li>src/plugins/render/earthquake/EarthquakeItem.cpp <span style="color: grey">(e1be854331cfebb94b22a5ff710938f613753e9f)</span></li>
<li>src/plugins/render/foursquare/FoursquareItem.cpp <span style="color: grey">(edab93c4ab6b810f50a14bb75247beeaa0e2382e)</span></li>
<li>src/plugins/render/measure/MeasureToolPlugin.cpp <span style="color: grey">(097d4e1bae0b6b833bf9e3852a354c7242a245bf)</span></li>
<li>src/plugins/render/opencaching/OpenCachingItem.cpp <span style="color: grey">(fd63059e8a89bd8f3a734e53814f9c2fd1422b06)</span></li>
<li>src/plugins/render/postalcode/PostalCodeItem.cpp <span style="color: grey">(dab8c5a13f114b658698b384ced2d6dc50758d85)</span></li>
<li>src/plugins/render/weather/WeatherItem.cpp <span style="color: grey">(2aef7afb82220ad83657307e840b19c454fbfa1f)</span></li>
<li>tests/TestEquality.cpp <span style="color: grey">(37666b597c768022f3ee692ae69db35fe92338d1)</span></li>
<li>tests/TestGeoDataCopy.cpp <span style="color: grey">(c354d8fc9a9edbe9027f432a9f03ef0bc658e3bb)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125011/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>