<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124781/">https://git.reviewboard.kde.org/r/124781/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Marble.</div>
<div>By Marius Stanciu.</div>
<p style="color: grey;"><i>Updated Aug. 26, 2015, 3:06 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Submitted with commit ce7381a5b7090d1c4544defb4d940ec4e207f4e0 by Marius Stanciu to branch master.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">!! Due to dependency issues on reviewboard, could not include the final version of src/lib/marble/osm/CMakeLists.txt
I've included this file separately</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">===TagEditor===
Tags can now be edited for text, polyline and polygon annotations.
The style changing occurs in the following manner:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Text annotations:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">If the icon link is empty, an icon is chosen from the current tags ( if available )
If the icon link is not empty, the custom icon is used.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Polylines and polygons:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">If the default style is initialized( #polygon and #polyline ) and there is a tag-based style available, the tag-based style is used.
If the style is not default, then the custom one is used.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">===RelationEditor===
The annotate plugin keeps a hash of all the relations loaded( from parsing, newly created relations )
Relations from this list are suggested in the Relations tab for all placemarks.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Normal use case:
1) Create a placemark
2) Add a new relation in the Relations tab
3) Create a new placemark
4) Add the relation created eariler for this placemark as well</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Done! A relation with two members has been created</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This might not be the final behaviour. Please do suggest a better rendering behaviour!</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">!TODO: gotta modify the parser and the writer to deal with these relations ( they can't be imported/exported atm ). Will do this in the next patch.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Created placemarks, polylines, polygons, added tags, removed tags, changed styles... works as expected.
Created placemarks, created relations, added placemarks to relations, removed relations, edited relations.... works as expected.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/lib/marble/EditPlacemarkDialog.h <span style="color: grey">(1ff59c2)</span></li>
<li>src/lib/marble/EditPlacemarkDialog.cpp <span style="color: grey">(ef295bb)</span></li>
<li>src/lib/marble/FileViewWidget.cpp <span style="color: grey">(b1c77c7)</span></li>
<li>src/lib/marble/TourItemDelegate.cpp <span style="color: grey">(834f1a7)</span></li>
<li>src/lib/marble/osm/OsmRelationManagerWidget.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/render/annotate/AnnotatePlugin.h <span style="color: grey">(dd29ee6)</span></li>
<li>src/plugins/render/annotate/AnnotatePlugin.cpp <span style="color: grey">(e98043b)</span></li>
<li>src/plugins/render/annotate/EditPolygonDialog.h <span style="color: grey">(6c58caa)</span></li>
<li>src/plugins/render/annotate/EditPolygonDialog.cpp <span style="color: grey">(28815a5)</span></li>
<li>src/plugins/render/annotate/EditPolylineDialog.h <span style="color: grey">(ae9177f)</span></li>
<li>src/plugins/render/annotate/EditPolylineDialog.cpp <span style="color: grey">(bacc6df)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124781/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/08/25/b3f1ecf8-b6d1-4bec-b38a-5017f039042a__CMakeLists.txt">final version of osm/CMakeLists.txt</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>