<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124817/">https://git.reviewboard.kde.org/r/124817/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Marble.</div>
<div>By Marius Stanciu.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">the osmObjectManager class assigns unique ids to newly created osm placemarks. In the next patches, a relation editor will be added, so this functionality will be needed inside the Annotate Plugin ( not available from the osm plugin )</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">compiles fine, no other tests needed</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/plugins/runner/osm/OsmObjectManager.h <span style="color: grey">(a521e07)</span></li>
<li>src/lib/marble/osm/CMakeLists.txt <span style="color: grey">(2aa67f7)</span></li>
<li>src/lib/marble/osm/OsmObjectManager.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/osm/OsmObjectManager.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/plugins/runner/osm/CMakeLists.txt <span style="color: grey">(b8cef82)</span></li>
<li>src/plugins/runner/osm/handlers/OsmNodeTagHandler.cpp <span style="color: grey">(24cd423)</span></li>
<li>src/plugins/runner/osm/OsmObjectManager.cpp <span style="color: grey">(259826f)</span></li>
<li>src/plugins/runner/osm/handlers/OsmRelationTagHandler.cpp <span style="color: grey">(ca91cbc)</span></li>
<li>src/plugins/runner/osm/handlers/OsmWayTagHandler.cpp <span style="color: grey">(fa74bde)</span></li>
<li>src/plugins/runner/osm/translators/OsmDocumentTagTranslator.cpp <span style="color: grey">(9f56d07)</span></li>
<li>src/plugins/runner/osm/translators/OsmPlacemarkTagTranslator.cpp <span style="color: grey">(5870ba2)</span></li>
<li>src/plugins/runner/osm/writers/OsmNodeTagWriter.cpp <span style="color: grey">(bff7a54)</span></li>
<li>src/plugins/runner/osm/writers/OsmObjectAttributeWriter.cpp <span style="color: grey">(b0cbd8d)</span></li>
<li>src/plugins/runner/osm/writers/OsmRelationTagWriter.cpp <span style="color: grey">(73f115b)</span></li>
<li>src/plugins/runner/osm/writers/OsmWayTagWriter.cpp <span style="color: grey">(0b8484c)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124817/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>