<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124664/">https://git.reviewboard.kde.org/r/124664/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 9th, 2015, 12:10 a.m. SAMT, <b>Dennis Nienhüser</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Looks fine.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I also discussed with Torsten how we can provide different icon sizes easily (larger ones would look better on Android). We don't have a final solution yet, but ideally we arrange icons in a directory structure such that we can load different sizes from a single string. E.g. providing a relative path 'restaurant.png' would lead to an automatic lookup in MarbleDirs for e.g. mapicons/16x16/restaurant.png, mapicons/22x22/restaurant.png and so on. Then we'd need something similar to QIcon that takes a couple of such icon variants and returns the best icon for a queried size (resizing if needed). This would be used internally to implement a new method <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">QImage GeoDataIconStyle::icon(const QSize &size)</code>; Probably we cannot use QIcon for that directly because it uses QPixmap internally which does not work with our icon queries coming from non-GUI threads.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Sounds good. Any suggetsions how can I get icons with large size? Also, probably we can use <a href="http://doc.qt.io/qt-5/qquickimageprovider.html" style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">QQuickImageProvider</a> for using simple Image{} from QML side.</p></pre>
<br />
<p>- Mihail</p>
<br />
<p>On August 9th, 2015, 10:49 a.m. SAMT, Mihail Ivchenko wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Marble.</div>
<div>By Mihail Ivchenko.</div>
<p style="color: grey;"><i>Updated Aug. 9, 2015, 10:49 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Add icons to search results in Marble Maps.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Works well on Nexus 5 & Nexus 9 (both are Android 5.1.1).</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/apps/marble-maps/SearchResults.qml <span style="color: grey">(f6caad10943769f002465ab2618d7900e35817a5)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124664/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/08/08/35dd9737-c1b1-4415-90fd-96392210940f__Screenshot_2015-08-08-18-12-42.png">Screenshot_2015-08-08-18-12-42.png</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>