<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124627/">https://git.reviewboard.kde.org/r/124627/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Thanks, the code looks much nicer now.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Some quick usage questions:
- How do I hide the "Modify Route" dialog to get back to the map? There is no menu item or button (shown) for it.
- What about making the current position the source by default (unless 'As departure' is clicked)? Right now there seems no way to include the current position in the route.</p></pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/124627/diff/3/?file=390913#file390913line101" style="color: black; font-weight: bold; text-decoration: underline;">src/apps/marble-maps/WaypointOrderManager.qml</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">101</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="nx">routingManager</span><span class="p">.</span><span class="nx">swapVia</span><span class="p">(</span><span class="nx">selectedItem</span><span class="p">,</span> <span class="nx">selectedItem</span><span class="o">+</span><span class="mi">1</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This button has no effect, probably it should be <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">swapVias</code> here?</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/124627/diff/3/?file=390924#file390924line224" style="color: black; font-weight: bold; text-decoration: underline;">src/lib/marble/routing/RouteRequest.cpp</a>
<span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">224</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">GeoDataPlacemark</span> <span class="n">temp</span> <span class="o">=</span> <span class="n">d</span><span class="o">-></span><span class="n">m_route</span><span class="p">[</span><span class="n">index1</span><span class="p">];</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Could also be a one-liner:
<code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">qSwap(d->m_route[index1], d->m_route[index2]);</code></p></pre>
</div>
</div>
<br />
<p>- Dennis Nienhüser</p>
<br />
<p>On August 7th, 2015, 9:35 p.m. UTC, Gábor Péterffy wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Marble.</div>
<div>By Gábor Péterffy.</div>
<p style="color: grey;"><i>Updated Aug. 7, 2015, 9:35 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This patch adds the following:</p>
<ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Redesigned routing UI</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Markers on the map</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Waypoint order editing</li>
</ul></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It works fine except one thing: when you call the redrawRoute() it draws the route until the first placemark, but if you changes the routing profile it draws the full road. Routing instructions are also missing in this case.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>data/android/drawable-xxxhdpi/place_orange.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/android/drawable-xxxhdpi/place_green.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/android/drawable-xxxhdpi/down.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/android/drawable-xxxhdpi/delete.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/android/drawable-xxxhdpi/place_red.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/android/drawable-xxxhdpi/place_white.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/android/drawable-xxxhdpi/up.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/apps/marble-maps/FloatingMenuButton.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/apps/marble-maps/MainScreen.qml <span style="color: grey">(fafd183)</span></li>
<li>src/apps/marble-maps/MarbleMaps.qrc <span style="color: grey">(713e414)</span></li>
<li>src/apps/marble-maps/NavigationSetup.qml <span style="color: grey">(eb7c1dd)</span></li>
<li>src/apps/marble-maps/ProfileSelectorMenu.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/apps/marble-maps/RoutingManager.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/apps/marble-maps/Search.qml <span style="color: grey">(14088b8)</span></li>
<li>src/apps/marble-maps/WaypointImage.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/apps/marble-maps/WaypointOrderManager.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/declarative/MarbleQuickItem.h <span style="color: grey">(4b1f729)</span></li>
<li>src/lib/marble/declarative/MarbleQuickItem.cpp <span style="color: grey">(feecb00)</span></li>
<li>src/lib/marble/declarative/Placemark.h <span style="color: grey">(8c17b4f)</span></li>
<li>src/lib/marble/declarative/Placemark.cpp <span style="color: grey">(27a9579)</span></li>
<li>src/lib/marble/declarative/RouteRequestModel.cpp <span style="color: grey">(c67eb51)</span></li>
<li>src/lib/marble/declarative/Routing.h <span style="color: grey">(51a1be7)</span></li>
<li>src/lib/marble/declarative/Routing.cpp <span style="color: grey">(7a0d8aa)</span></li>
<li>src/lib/marble/declarative/SearchBackend.h <span style="color: grey">(86924f2)</span></li>
<li>src/lib/marble/declarative/SearchBackend.cpp <span style="color: grey">(b215d7c)</span></li>
<li>src/lib/marble/routing/RouteRequest.h <span style="color: grey">(60b768b)</span></li>
<li>src/lib/marble/routing/RouteRequest.cpp <span style="color: grey">(441972b)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124627/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/08/05/c34d1f1c-cdb8-4f4b-9c0f-7c9fc479c5a5__place_white.png">place_white.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/08/05/0dd988f0-189e-4ce6-8dd8-5f4e8f07713a__up.png">up.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/08/05/f0557e37-7c1b-4447-93d2-201c8b05efe4__down.png">down.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/08/05/fb26b212-cfc0-40d4-90ac-29bbe514dec4__delete.png">delete.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/08/05/85a13541-3168-499b-9c6a-776f889fe5d7__Screenshot_2015-08-06-01-44-58.png">Screenshot I</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/08/05/2dca53bf-7941-4bd0-8ec2-1e517e915ae8__Screenshot_2015-08-06-01-43-41.png">Screenshot II</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/08/05/7b24796b-a13c-4508-87c7-9861f779a15c__Screenshot_2015-08-06-01-44-51.png">Screenshot III</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/08/07/323cdff6-7ee6-4d05-a8f1-15e92c6365b6__place_orange.png">place_orange.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/08/07/7221416f-7b47-45cf-b5df-ac435b1a3b04__place_green.png">place_green.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/08/07/8decaaeb-8819-400e-8589-e37e9fa7e98d__place_red.png">place_red.png</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>