<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124579/">https://git.reviewboard.kde.org/r/124579/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>
<br />
<p>- Torsten Rahn</p>
<br />
<p>On August 1st, 2015, 4:49 nachm. UTC, Dennis Nienhüser wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Marble.</div>
<div>By Dennis Nienhüser.</div>
<p style="color: grey;"><i>Updated Aug. 1, 2015, 4:49 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Prefers passing a file path to instantiate GeoDataIconStyle instead of passing a QImage directly. This leads to slightly faster startup times (the icons of the static default styles are now lazy-loaded) and allows querying the iconPath in more cases. The latter is beneficial for QML images. Icon paths are also exported in MarblePlacemarkModel.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Icons still show up nicely on the map and in the search list view. Startup is slightly faster (e.g. GeoDataFeaturePrivate::initializeDefaultStyles() is reduced from 15 ms to 5 ms on my laptop. It is called three times during startup. Not sure why it is called more than once, possibly due to different libraries using it, i.e. marblewidget and some plugins).</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/lib/marble/BookmarkManagerDialog.cpp <span style="color: grey">(72f716c)</span></li>
<li>src/lib/marble/EditBookmarkDialog.cpp <span style="color: grey">(2f7e80f)</span></li>
<li>src/lib/marble/MarblePlacemarkModel.h <span style="color: grey">(1eacbb4)</span></li>
<li>src/lib/marble/MarblePlacemarkModel.cpp <span style="color: grey">(fd96f35)</span></li>
<li>src/lib/marble/TourWidget.cpp <span style="color: grey">(95d6891)</span></li>
<li>src/lib/marble/geodata/data/GeoDataFeature.cpp <span style="color: grey">(6f330fb)</span></li>
<li>src/lib/marble/geodata/data/GeoDataFeature_p.h <span style="color: grey">(496c356)</span></li>
<li>src/lib/marble/geodata/data/GeoDataIconStyle.h <span style="color: grey">(09f8a7c)</span></li>
<li>src/lib/marble/geodata/data/GeoDataIconStyle.cpp <span style="color: grey">(349db42)</span></li>
<li>src/lib/marble/geodata/data/GeoDataStyle.h <span style="color: grey">(4cef3a9)</span></li>
<li>src/lib/marble/geodata/data/GeoDataStyle.cpp <span style="color: grey">(76da532)</span></li>
<li>src/plugins/render/annotate/PlacemarkTextAnnotation.cpp <span style="color: grey">(64336da)</span></li>
<li>src/plugins/render/satellites/SatellitesModel.cpp <span style="color: grey">(8cdf8de)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124579/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>