<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124622/">https://git.reviewboard.kde.org/r/124622/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/124622/diff/2/?file=390260#file390260line181" style="color: black; font-weight: bold; text-decoration: underline;">src/apps/marble-maps/MainScreen.qml</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">181</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="nx">property</span> <span class="nx">bool</span> <span class="k">departureSetted:</span> <span class="kc">false</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">There is no word such as "Setted"
Make that </p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">departureIsSet()
destinationIsSet()</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">or (...isSpecified())
or</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">departureAvailable()
destinationAvailable()</p></pre>
</div>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/124622/diff/2/?file=390265#file390265line13" style="color: black; font-weight: bold; text-decoration: underline;">src/apps/marble-maps/Search.qml</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">13</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="nx">signal</span> <span class="nx">requestNavigation</span><span class="p">()</span></pre></td>
</tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Signals are always named in past/present perfect tense. This should be named:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">signal navigationRequested()</p></pre>
</div>
</div>
<br />
<p>- Torsten Rahn</p>
<br />
<p>On August 5th, 2015, 11:16 vorm. UTC, Gábor Péterffy wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Marble.</div>
<div>By Gábor Péterffy.</div>
<p style="color: grey;"><i>Updated Aug. 5, 2015, 11:16 vorm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This patch contains a minimalistic ui for routing.</p>
<ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Planning route to destination from current position</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Planning route from setted departure</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Planning route with waypoints</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Instructions in the menu</li>
</ul>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">What is missing:
- Waypoint markers for the map, these will come in a new patch.
- Maybe a loading screen while route planning in progress</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It works well on my device, everything fits and has right positioning.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>data/android/drawable-xxxhdpi/bike.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/android/drawable-xxxhdpi/car.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/android/drawable-xxxhdpi/map.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/android/drawable-xxxhdpi/navigation.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/android/drawable-xxxhdpi/place.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/android/drawable-xxxhdpi/walk.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/android/drawable-xxxhdpi/waypoint.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/apps/marble-maps/CircularButton.qml <span style="color: grey">(93a09c0)</span></li>
<li>src/apps/marble-maps/MainScreen.qml <span style="color: grey">(b8dc7b0)</span></li>
<li>src/apps/marble-maps/MarbleMaps.qrc <span style="color: grey">(0168893)</span></li>
<li>src/apps/marble-maps/NavigationSetup.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/apps/marble-maps/NavigationSetupButton.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/apps/marble-maps/RoutePlanViewer.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/apps/marble-maps/Search.qml <span style="color: grey">(9b712c8)</span></li>
<li>src/lib/marble/declarative/Coordinate.h <span style="color: grey">(db2ab9f)</span></li>
<li>src/lib/marble/declarative/Coordinate.cpp <span style="color: grey">(bbdc829)</span></li>
<li>src/lib/marble/declarative/MarbleDeclarativePlugin.cpp <span style="color: grey">(3bf2198)</span></li>
<li>src/lib/marble/declarative/MarbleQuickItem.h <span style="color: grey">(cefb0c0)</span></li>
<li>src/lib/marble/declarative/MarbleQuickItem.cpp <span style="color: grey">(f8c396f)</span></li>
<li>src/lib/marble/declarative/Routing.h <span style="color: grey">(182fe64)</span></li>
<li>src/lib/marble/declarative/Routing.cpp <span style="color: grey">(dbbcb80)</span></li>
<li>src/lib/marble/declarative/SearchBackend.h <span style="color: grey">(4981c31)</span></li>
<li>src/lib/marble/declarative/SearchBackend.cpp <span style="color: grey">(fdef702)</span></li>
<li>src/lib/marble/routing/Maneuver.cpp <span style="color: grey">(c0ab724)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124622/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/08/04/f39163fa-12ab-4aa2-a787-9c43e5d54177__bike.png">bike.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/08/04/21576ef7-f5c8-4cb2-b731-63e14bdb51db__walk.png">walk.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/08/04/373c2a86-625c-4380-b699-0acbdd269a9d__place.png">place.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/08/04/7adf250e-4a25-4ddd-a1a6-5e9e6d905ee1__navigation.png">navigation.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/08/04/efe967e2-0ae1-4ac0-8678-8b2cea4e32b1__map.png">map.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/08/04/9e5f5f87-352c-4e70-b7ae-cdf8be296863__car.png">car.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/08/04/2fcdc0b5-6552-4a89-bf55-ecf9b50e1605__waypoint.png">waypoint.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/08/04/08bed68d-5ec3-43a1-98ac-467fc8aa94da__Screenshot_2015-08-04-22-39-57.png">Screenshot I.</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/08/04/f2cc5de7-f966-496a-bbe1-2b24859511c1__Screenshot_2015-08-04-22-39-52.png">Screenshot II.</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/08/04/76795bf1-590f-4e61-bb67-1cb10ed6870b__Screenshot_2015-08-04-22-39-24.png">Screenshot III</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/08/04/8f8d1795-d751-4ee9-bec0-eee3404b15b4__Screenshot_2015-08-04-22-39-11.png">Screenshot IV</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/08/04/ba50137d-21ec-4759-b6f4-38cbe882f47e__Screenshot_2015-08-04-22-38-03.png">Screenshot V</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>