<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124553/">https://git.reviewboard.kde.org/r/124553/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Marble.</div>
<div>By Marius Stanciu.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It seems storing data with pointer keys within a QHash wasn't a good idea:
A polygon's inner boundaries are stored within a QVector, which reallocates it's objects sometimes, thus pointers to inner boundaries are not constant.
Changed the key to int with the following meaning:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">-1 ===> outer boundary of a polygon
0,1,2,3...etc =====> inner boundaries of a polygon in the order provided by polygon->innerBoundaries() ( the QVector order )</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This wasn't a problem until I started modiying inner boundaries in the editor.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Usual tests ( added polygons, imported, exported, reimported ), stuff works as expected.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/lib/marble/osm/OsmPlacemarkData.h <span style="color: grey">(58f7e69)</span></li>
<li>src/lib/marble/osm/OsmPlacemarkData.cpp <span style="color: grey">(c78888b)</span></li>
<li>src/plugins/runner/osm/OsmObjectManager.cpp <span style="color: grey">(85f78d2)</span></li>
<li>src/plugins/runner/osm/handlers/OsmMemberTagHandler.cpp <span style="color: grey">(2e1c9b7)</span></li>
<li>src/plugins/runner/osm/translators/OsmDocumentTagTranslator.cpp <span style="color: grey">(cac7852)</span></li>
<li>src/plugins/runner/osm/writers/OsmRelationTagWriter.cpp <span style="color: grey">(8f79a17)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124553/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>