<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124521/">https://git.reviewboard.kde.org/r/124521/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Marble.</div>
<div>By Marius Stanciu.</div>
<p style="color: grey;"><i>Updated July 31, 2015, 3:35 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Submitted with commit 73d69065414fc252f253348388911533ba05ea5d by Marius Stanciu to branch master.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Added the "mx" namespace, needed to separate the upcoming custom XML schema</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Added an easy osmPlacemarkData setter for GeoDataPlacemark, in order to avoid working with GeoExtendedData and hash entries all the time</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Made the OsmPlacemarkData osmAttributeData() const an OsmPlacemarkData constructor, because it will be needed from the KmlParser sources as well
( not available from OsmParser.h )</li>
</ul></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">compiles fine, no real changes to test.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/lib/marble/geodata/data/GeoDataPlacemark.h <span style="color: grey">(f1eadd8)</span></li>
<li>src/lib/marble/geodata/data/GeoDataPlacemark.cpp <span style="color: grey">(de36b5e)</span></li>
<li>src/lib/marble/geodata/handlers/kml/KmlElementDictionary.h <span style="color: grey">(f2c062c)</span></li>
<li>src/lib/marble/geodata/handlers/kml/KmlElementDictionary.cpp <span style="color: grey">(ea53d43)</span></li>
<li>src/lib/marble/geodata/parser/GeoDataParser.cpp <span style="color: grey">(588b086)</span></li>
<li>src/lib/marble/osm/OsmPlacemarkData.h <span style="color: grey">(58f7e69)</span></li>
<li>src/lib/marble/osm/OsmPlacemarkData.cpp <span style="color: grey">(c78888b)</span></li>
<li>src/plugins/runner/kml/KmlParser.cpp <span style="color: grey">(4a9fa6a)</span></li>
<li>src/plugins/runner/osm/OsmParser.h <span style="color: grey">(141f4f6)</span></li>
<li>src/plugins/runner/osm/OsmParser.cpp <span style="color: grey">(c9b63b0)</span></li>
<li>src/plugins/runner/osm/handlers/OsmNodeTagHandler.cpp <span style="color: grey">(1f6160f)</span></li>
<li>src/plugins/runner/osm/handlers/OsmRelationTagHandler.cpp <span style="color: grey">(892adb5)</span></li>
<li>src/plugins/runner/osm/handlers/OsmTagTagHandler.h <span style="color: grey">(9bf9e0c)</span></li>
<li>src/plugins/runner/osm/handlers/OsmTagTagHandler.cpp <span style="color: grey">(d3fd2f2)</span></li>
<li>src/plugins/runner/osm/handlers/OsmWayTagHandler.cpp <span style="color: grey">(cb84d5c)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124521/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>