<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124522/">https://git.reviewboard.kde.org/r/124522/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Marble.</div>
<div>By Marius Stanciu.</div>
<p style="color: grey;"><i>Updated July 31, 2015, 5:37 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description (updated)</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This completes the parsing/writing cycle: load ".osm" -> export as ".kml" -> import ".kml" -> export ".osm" -> repeat</p>
</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I have made the custom XML schema very verbose, so as to be understandable and have a KMLish XML style.
If you think it's too verbose. I can eliminate the <member> and <nd> wrapper tags and save their data
as attributes</p>
</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">One small change had to be done: ExtendedData is now written after the Geometry within a <Placemark> tag ( @see change in KmlFeatureTagWriter.cpp )
( OsmPlacemarkData depends on the geometry, so that has to be initialized before, when parsing ".kml" files )</p>
</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">There is one known issue: if you import polygons from a ".osm" file, the polygon()->outerBoundary().nodeType() is GeoDataLineStringType, not GeoDataLinearRingType as it should be
( this, when written in ".kml" will result such a thing:
<Polygon>
<outerBoundaryIs>
<LineString> // this should be <LinearRing>
<coordinates>-5.7129150009,-16.0033060822 -5.7131777661,-16.0038067061 -5.7124571297,-16.0041031487 -5.7119945396,-16.0034240531 -5.7124492636,-16.0031684483 -5.7129150009,-16.0033060822</coordinates>
</LineString> )</p>
</li>
</ul>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I know what causes the issue, and i'm currently currently trying to fix it ( GeoDataLinearRing::GeoDataLinearRing( const GeoDataGeometry & other ) constructor does not initialize
it's own GeoDataLinearRingPrivate member )</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">created stuff within editor then done the cycle: export as ".osm" ----> load ".osm" ----> export as ".kml" ----> import ".kml" ----> export ".osm"
compared the initial ".osm" file with the last one, they are the same. ( except tag order inconsistencies cause by the QHash mechanism )
Unit tests coming soon.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/lib/marble/geodata/CMakeLists.txt <span style="color: grey">(cb89e7f)</span></li>
<li>src/lib/marble/geodata/handlers/kml/KmlMemberTagHandler.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/geodata/handlers/kml/KmlMemberTagHandler.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/geodata/handlers/kml/KmlNdTagHandler.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/geodata/handlers/kml/KmlNdTagHandler.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/geodata/handlers/kml/KmlOsmPlacemarkDataTagHandler.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/geodata/handlers/kml/KmlOsmPlacemarkDataTagHandler.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/geodata/handlers/kml/KmlTagTagHandler.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/geodata/handlers/kml/KmlTagTagHandler.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/geodata/writers/kml/KmlFeatureTagWriter.cpp <span style="color: grey">(f4a77ff)</span></li>
<li>src/lib/marble/geodata/writers/kml/KmlOsmPlacemarkDataTagWriter.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/lib/marble/geodata/writers/kml/KmlOsmPlacemarkDataTagWriter.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124522/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>