<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124519/">https://git.reviewboard.kde.org/r/124519/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On July 30th, 2015, 7:05 p.m. CEST, <b>Dennis Nienhüser</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/124519/diff/2/?file=388743#file388743line390" style="color: black; font-weight: bold; text-decoration: underline;">src/lib/marble/MarbleQuickItem.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">namespace Marble</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">390</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">return</span> <span class="n">atan2</span><span class="p">(</span><span class="n">y1</span><span class="o">-</span><span class="n">y2</span><span class="p">,</span> <span class="n">x1</span><span class="o">-</span><span class="n">x2</span><span class="p">)</span> <span class="o">*</span> <span class="n">RAD2DEG</span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">use position.y() for y2 and position.x() for x2 and spare the redundant screen => geo => screen transformations above.</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">In this case it not maps the coordinate to the global map. Am I missing a function what is alredy exists to do this?</p></pre>
<br />
<p>- Gábor</p>
<br />
<p>On August 1st, 2015, 1:23 a.m. CEST, Gábor Péterffy wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Marble.</div>
<div>By Gábor Péterffy.</div>
<p style="color: grey;"><i>Updated Aug. 1, 2015, 1:23 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This patch introduces the CircleButton qml type. Based on this there is a button now which navigates the map at the current position.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It seems my distance or angle functions are not working well, the almost always provide false data after some panning (my position is sometimes start to change when I am panning on the map, strange thing: the position marker also starts to go to an other place like it is fixed to the screen, but the map moves under it sometimes when I am penning and it is not jumping back to its place.)</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>data/android/drawable-xxxhdpi/backdrop.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/android/drawable-xxxhdpi/gps_fixed.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/android/drawable-xxxhdpi/gps_not_fixed.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>data/android/drawable-xxxhdpi/marblelogo.png <span style="color: grey">(bf462f7608169f70cc014d8da1e0ad86e11bed15)</span></li>
<li>src/apps/marble-maps/BoxedText.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/apps/marble-maps/CircularButton.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/apps/marble-maps/IndicatorCircularButton.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/apps/marble-maps/MainScreen.qml <span style="color: grey">(2cc996aef7b89f888f822ef4ff3bf5460c729991)</span></li>
<li>src/apps/marble-maps/MarbleMaps.qrc <span style="color: grey">(d027af982f31144107baedf77fe07f7239ef53ed)</span></li>
<li>src/lib/marble/declarative/MarbleQuickItem.h <span style="color: grey">(cca329761f23cd72315df2d359166a2cbfa8056c)</span></li>
<li>src/lib/marble/declarative/MarbleQuickItem.cpp <span style="color: grey">(e7dbbe7de31858286f6d0e38f5721f7f8ae45e79)</span></li>
<li>src/plugins/positionprovider/qtpositioning/QtPositioningPositionProviderPlugin.cpp <span style="color: grey">(35884a7c844b590ecf44f3346f0d41b4c46b0f81)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124519/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/07/30/35409caf-2dbd-4fc4-b495-43fe1d8e4279__gps_not_fixed.png">gps_not_fixed.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/07/30/019abdbb-80cf-4935-8d6d-0c3e6927d2b3__gps_fixed.png">gps_fixed.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/07/31/ebaa4d45-b337-4e42-8a23-a73e2d88ddca__marblelogo.png">marblelogo.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/07/31/dacf5958-7270-40c4-9031-243350a80de8__backdrop.png">backdrop.png</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>