<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124526/">https://git.reviewboard.kde.org/r/124526/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Marble.</div>
<div>By Dennis Nienhüser.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=350749">350749</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">qt4/Qt/qconfig.h sets QT_NO_WEBKIT without checking whether it is installed or not. This screws up our logic later on. The patch moves from QT_NO_WEBKIT to MARBLE_NO_WEBKIT and tries to guess its value based on the cmake checks if not given from the command line.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The patch is for master, a backport for Applications/15.04 is at http://nienhueser.de/marble/marble-nowebkit-1508-1.diff</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Compiling Applications/15.04 branch with Qt 4.8 + QtWebKit installed, and master with Qt 5.5 Desktop and Qt 5.5 Android</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(e77f746)</span></li>
<li>src/apps/marble-mobile/MobileMainWindow.cpp <span style="color: grey">(89db918)</span></li>
<li>src/lib/marble/CMakeLists.txt <span style="color: grey">(78f5395)</span></li>
<li>src/lib/marble/LegendWidget.cpp <span style="color: grey">(8158416)</span></li>
<li>src/lib/marble/MarbleLegendBrowser.h <span style="color: grey">(936eedb)</span></li>
<li>src/lib/marble/MarbleLegendBrowser.cpp <span style="color: grey">(3af1f80)</span></li>
<li>src/lib/marble/PopupItem.h <span style="color: grey">(9947a78)</span></li>
<li>src/lib/marble/PopupItem.cpp <span style="color: grey">(41e108a)</span></li>
<li>src/lib/marble/cloudsync/RouteItemDelegate.cpp <span style="color: grey">(03be997)</span></li>
<li>src/lib/marble/routing/RoutingInputWidget.cpp <span style="color: grey">(2ec32f0)</span></li>
<li>src/plugins/render/CMakeLists.txt <span style="color: grey">(bffeb6b)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124526/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>