<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124493/">https://git.reviewboard.kde.org/r/124493/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On July 27th, 2015, 7:54 p.m. UTC, <b>Dennis Nienhüser</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/124493/diff/1/?file=388123#file388123line32" style="color: black; font-weight: bold; text-decoration: underline;">src/plugins/positionprovider/CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">20</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="nb">macro_optional_find_package</span><span class="p">(</span><span class="s">QtLocation</span><span class="p">)</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">32</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="nb">macro_optional_find_package</span><span class="p">(</span><span class="s">QtLocation</span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Shall we just get rid of the Qt4 stuff here?</p></pre>
</blockquote>
<p>On July 28th, 2015, 7:01 a.m. UTC, <b>Gábor Péterffy</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Has this plugin active use in other applications?</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It was used in the Maemo version, which is obsolete now. I'm not aware of other usages, so generally I wouldn't mind stripping anything Qt 4 related and even renaming it QtPositioning.</p></pre>
<br />
<p>- Dennis</p>
<br />
<p>On July 27th, 2015, 9:50 p.m. UTC, Gábor Péterffy wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Marble.</div>
<div>By Gábor Péterffy.</div>
<p style="color: grey;"><i>Updated July 27, 2015, 9:50 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I have updated the qtmobility plugin to be able to compile with Qt5, and I also enabled the PositionMarker render plugin for Marble Maps.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Focusing to the current position will be in a new patch. Also I think the current position marker has to be redesigned for the osm theme because now it is hiding (see the screenshot).</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(e74694a0da8507415a9a5472c4f09dfe2561f846)</span></li>
<li>src/apps/marble-maps/CMakeLists.txt <span style="color: grey">(fff00ffc5ee4dcb3a78b5cdea18035e9267df1e9)</span></li>
<li>src/apps/marble-maps/MainScreen.qml <span style="color: grey">(5552a54eca8b37fa17588a14a035927418b23fbe)</span></li>
<li>src/apps/marble-maps/create-apk.py <span style="color: grey">(f5fa5489aae2780b04f61b32b21e4c45bd3df85b)</span></li>
<li>src/apps/marble-maps/package/AndroidManifest.xml <span style="color: grey">(3eee53b142c444a3f456208220b3e91ef5759219)</span></li>
<li>src/lib/marble/MarbleQuickItem.h <span style="color: grey">(21b8fe5c4570ac894f668603a660da81f1d8a8e4)</span></li>
<li>src/lib/marble/MarbleQuickItem.cpp <span style="color: grey">(ee8bae8ea379cae3a0e6378259622a1ad88f8a2b)</span></li>
<li>src/plugins/positionprovider/CMakeLists.txt <span style="color: grey">(f9bfdd691d1905db29cad41af769320c694cd324)</span></li>
<li>src/plugins/positionprovider/qtmobility/CMakeLists.txt <span style="color: grey">(502513afef8f9bb9b23d70eb868c7a751c7fc4d6)</span></li>
<li>src/plugins/positionprovider/qtmobility/QtMobilityPositionProviderPlugin.cpp <span style="color: grey">(a2e6dca574564938813ed06466bf67b1a9900fcb)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124493/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/07/27/22c65232-7061-4ec5-86f1-de4acbd95e05__Screenshot_2015-07-27-19-04-35.png">Screenshot</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>